Skip to content

Commit b109c02

Browse files
committed
Fix Dockerfile.dev
home-assistant#34654 broke the dev dockerfile, so I'm trying to fix it. - fix the leading && by putting a valid no-op command before it to maintain formatting - remove the apt-add-repository, it's unclear why it was added and it's broken. - also add a CI step that tries to build the dockerfile to validate it.
1 parent de3f0c7 commit b109c02

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

Dockerfile.dev

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
FROM python:3.8
22

3-
RUN \
3+
RUN true \
44
&& apt-get update && apt-get install -y --no-install-recommends \
55
software-properties-common \
6-
&& add-apt-repository ppa:jonathonf/ffmpeg-4 \
7-
&& apt-get update && apt-get install -y --no-install-recommends \
6+
&& apt-get update \
7+
&& apt-get install -y --no-install-recommends \
88
libudev-dev \
99
libavformat-dev \
1010
libavcodec-dev \

azure-pipelines-ci.yml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,16 @@ stages:
121121
. venv/bin/activate
122122
pre-commit run black --all-files --show-diff-on-failure
123123
displayName: "Check Black formatting"
124-
124+
- job: "ValidateDockerfiles"
125+
pool:
126+
vmImage: "ubuntu-latest"
127+
steps:
128+
- task: Docker@2
129+
displayName: Build Dockerfile.dev
130+
inputs:
131+
repository: homeassistant-dev
132+
command: build
133+
Dockerfile: Dockerfile.dev
125134
- stage: "Tests"
126135
dependsOn:
127136
- "Overview"

0 commit comments

Comments
 (0)