Skip to content

Commit 468727a

Browse files
Merge pull request git-for-windows#215: gvfs-helper: dramatically reduce progress noise
During development, it was very helpful to see the gvfs-helper do its work to request a pack-file or download a loose object. When these messages appear during normal use, it leads to a very noisy terminal output. Remove all progress indicators when downloading loose objects. We know that these can be numbered in the thousands in certain kinds of history calls, and would litter the terminal output with noise. This happens during 'git fetch' or 'git pull' as well when the tip commits are checked for the new refs. Remove the "Requesting packfile with %ld objects" message, as this operation is very fast. We quickly follow up with the more valuable "Receiving packfile %ld%ld with %ld objects". When a large "git checkout" causes many pack-file downloads, it is good to know that Git is asking for data from the server.
2 parents a782a7e + 6e92f6a commit 468727a

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

gvfs-helper.c

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2528,17 +2528,11 @@ static void setup_gvfs_objects_progress(struct gh__request_params *params,
25282528
return;
25292529

25302530
if (params->b_is_post && params->object_count > 1) {
2531-
strbuf_addf(&params->progress_base_phase2_msg,
2532-
"Requesting packfile %ld/%ld with %ld objects",
2533-
num, den, params->object_count);
25342531
strbuf_addf(&params->progress_base_phase3_msg,
25352532
"Receiving packfile %ld/%ld with %ld objects",
25362533
num, den, params->object_count);
2537-
} else {
2538-
strbuf_addf(&params->progress_base_phase3_msg,
2539-
"Receiving %ld/%ld loose object",
2540-
num, den);
25412534
}
2535+
/* If requesting only one object, then do not show progress */
25422536
}
25432537

25442538
/*

0 commit comments

Comments
 (0)