Skip to content

Commit 09f61da

Browse files
author
Joan Fontanals
authored
fix: pass allow_concurrent to runtime_args (#6188)
1 parent 3ca71a5 commit 09f61da

File tree

6 files changed

+12
-11
lines changed

6 files changed

+12
-11
lines changed

jina/orchestrate/deployments/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1883,9 +1883,9 @@ def to_docker_compose_yaml(
18831883
yaml.dump(docker_compose_dict, fp, sort_keys=False)
18841884

18851885
command = (
1886-
'docker-compose up'
1886+
'docker compose up'
18871887
if output_path is None
1888-
else f'docker-compose -f {output_path} up'
1888+
else f'docker compose -f {output_path} up'
18891889
)
18901890

18911891
self.logger.info(

jina/orchestrate/flow/base.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2851,9 +2851,9 @@ def to_docker_compose_yaml(
28512851
yaml.dump(docker_compose_dict, fp, sort_keys=False)
28522852

28532853
command = (
2854-
'docker-compose up'
2854+
'docker compose up'
28552855
if output_path is None
2856-
else f'docker-compose -f {output_path} up'
2856+
else f'docker compose -f {output_path} up'
28572857
)
28582858

28592859
self.logger.info(

jina/serve/runtimes/worker/request_handling.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -399,6 +399,7 @@ def _load_executor(
399399
'metrics_registry': metrics_registry,
400400
'tracer_provider': tracer_provider,
401401
'meter_provider': meter_provider,
402+
'allow_concurrent': self.args.allow_concurrent,
402403
},
403404
py_modules=self.args.py_modules,
404405
extra_search_paths=self.args.extra_search_paths,

tests/conftest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@ def test_metas(tmpdir, random_workspace_name):
3131
@pytest.fixture()
3232
def docker_compose(request):
3333
os.system(
34-
f"docker-compose -f {request.param} --project-directory . up --build -d --remove-orphans"
34+
f"docker compose -f {request.param} --project-directory . up --build -d --remove-orphans"
3535
)
3636
time.sleep(10)
3737
yield
3838
os.system(
39-
f"docker-compose -f {request.param} --project-directory . down --remove-orphans"
39+
f"docker compose -f {request.param} --project-directory . down --remove-orphans"
4040
)
4141

4242

tests/docker_compose/conftest.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,14 +81,14 @@ def __init__(self, dump_path, timeout_second=30):
8181

8282
def __enter__(self):
8383
subprocess.run(
84-
f'docker-compose -f {self.dump_path} up --build -d --remove-orphans'.split(
84+
f'docker compose -f {self.dump_path} up --build -d --remove-orphans'.split(
8585
' '
8686
)
8787
)
8888

8989
container_ids = (
9090
subprocess.run(
91-
f'docker-compose -f {self.dump_path} ps -q'.split(' '),
91+
f'docker compose -f {self.dump_path} ps -q'.split(' '),
9292
capture_output=True,
9393
)
9494
.stdout.decode("utf-8")
@@ -127,5 +127,5 @@ def _are_all_container_healthy(
127127

128128
def __exit__(self, exc_type, exc_val, exc_tb):
129129
subprocess.run(
130-
f'docker-compose -f {self.dump_path} down --remove-orphans'.split(' ')
130+
f'docker compose -f {self.dump_path} down --remove-orphans'.split(' ')
131131
)

tests/integration/instrumentation/conftest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,12 @@ def otlp_receiver_port():
3535
def otlp_collector(jaeger_port, prometheus_backend_port, otlp_receiver_port):
3636
file_dir = os.path.dirname(__file__)
3737
os.system(
38-
f"docker-compose -f {os.path.join(file_dir, 'docker-compose.yml')} up -d --remove-orphans"
38+
f"docker compose -f {os.path.join(file_dir, 'docker-compose.yml')} up -d --remove-orphans"
3939
)
4040
time.sleep(1)
4141
yield
4242
os.system(
43-
f"docker-compose -f {os.path.join(file_dir, 'docker-compose.yml')} down --remove-orphans"
43+
f"docker compose -f {os.path.join(file_dir, 'docker-compose.yml')} down --remove-orphans"
4444
)
4545

4646

0 commit comments

Comments
 (0)