feat(as3): allow display of duplicate classes, warn (#2710, #2254)

ScriptPacks that are duplicate - multiple packs with the same name
exist - are displayed and can be edited / deleted / ...

Previously, there was SEVERE error logged when such state was
detected, now only WARNING is issued.

Author: jindrapetrik

libsrc/ffdec_lib/src/com/jpexs/decompiler/flash/SWF.java

@@ -3165,25 +3165,22 @@ public List<ScriptPack> getScriptPacksByClassNames(List<String> classNames) thro
     }
 
     /**
-     * Makes scriptpacks unique. Unique = no two packs with same classpath
+     * Checks scriptpacks whether they are unique. Unique = no two packs with same classpath
      * exist.
      *
      * @param packs List of ScriptPacks
      * @return List of unique ScriptPacks
      */
-    private List<ScriptPack> uniqueAS3Packs(List<ScriptPack> packs) {
-        List<ScriptPack> ret = new ArrayList<>();
+    private void checkUniqueAS3Packs(List<ScriptPack> packs) {
         Set<ClassPath> classPaths = new HashSet<>();
         for (ScriptPack item : packs) {
             ClassPath key = item.getClassPath();
             if (classPaths.contains(key) && item.isSimple) {
-                logger.log(Level.SEVERE, "Duplicate pack path found ({0})!", key);
+                logger.log(Level.WARNING, "Duplicate scriptpack path found ({0})!", key);
             } else {
-                classPaths.add(key);
-                ret.add(item);
+                classPaths.add(key);                
             }
-        }
-        return ret;
+        }        
     }
 
     /**
@@ -3205,7 +3202,8 @@ public List<ScriptPack> getAS3Packs() {
         for (ABCContainerTag abcTag : abcList) {
             packs.addAll(abcTag.getABC().getScriptPacks(null, allAbcList));
         }
-        return uniqueAS3Packs(packs);
+        checkUniqueAS3Packs(packs);        
+        return packs;
     }
 
     /**

libsrc/ffdec_lib/src/com/jpexs/decompiler/flash/timeline/AS3Package.java

@@ -273,10 +273,15 @@ public List<ScriptPack> getScriptPacks() {
      *
      * @param script ScriptPack
      */
-    public void addScriptPack(ScriptPack script) {        
-        /*ClassPath cp = script.getClassPath();
-        scripts.put(cp.className + cp.namespaceSuffix, script);*/
-        scripts.put(script.getPrintableNameWithNamespaceSuffix(), script);
+    public void addScriptPack(ScriptPack script) {    
+        int i = 1;
+        String baseKey = script.getPrintableNameWithNamespaceSuffix();
+        String key = baseKey;
+        while (scripts.containsKey(key)) {
+            i++;
+            key = baseKey + i;
+        }
+        scripts.put(key, script);
         sortedScripts = null;
     }