Upgrade to go=1.24

Author: jmcfarlane

.github/workflows/test.yaml

@@ -1,55 +1,40 @@
+---
 name: Go package
-
-on:
-  - push
-
+on: [push]
 jobs:
   test:
     strategy:
       matrix:
-        go-version:
-          - 1.20.x
-          - 1.19.x
-          - 1.18.x
-        os:
-          - ubuntu-latest
+        go-version: [1.24.x, 1.23.x]
+        os: [ubuntu-latest]
     runs-on: ${{ matrix.os }}
-
     steps:
       - name: Go version
         run: go version
-
       - name: Go env
         run: go env
 
       # https://github.com/actions/checkout
       - name: checkout repo
         uses: actions/checkout@v3
-
       - name: Test
         run: make test vet
   build:
     strategy:
       matrix:
-        go-version:
-          - 1.20.x
-        os:
-          - ubuntu-latest
+        go-version: [1.24.x]
+        os: [ubuntu-latest]
     runs-on: ${{ matrix.os }}
-
     steps:
       - name: Install dependencies
         run: sudo apt-get install -y imagemagick icnsutils zip
-
       - name: Go version
         run: go version
-
       - name: Go env
         run: go env
 
       # https://github.com/actions/checkout
       - name: checkout repo
         uses: actions/checkout@v3
-
       - name: Build
         run: make build

go.mod

@@ -1,6 +1,8 @@
 module github.com/jmcfarlane/notable
 
-go 1.20
+go 1.24
+
+toolchain go1.24.2
 
 require (
 	github.com/blevesearch/bleve/v2 v2.3.7

handlers.go

@@ -23,18 +23,18 @@ func createNote(w http.ResponseWriter, r *http.Request) {
 	json.Unmarshal(payload, &note)
 	note, err := db.create(note)
 	if err != nil {
-		fmt.Fprintf(w, err.Error())
+		fmt.Fprint(w, err.Error())
 	}
 	noteJSON, err := note.ToJSON()
 	if err != nil {
-		fmt.Fprintf(w, err.Error())
+		fmt.Fprint(w, err.Error())
 	}
-	fmt.Fprintf(w, noteJSON)
+	fmt.Fprint(w, noteJSON)
 }
 
 // The current process id
 func pid(w http.ResponseWriter, r *http.Request) {
-	fmt.Fprintf(w, strconv.Itoa(os.Getpid()))
+	fmt.Fprint(w, strconv.Itoa(os.Getpid()))
 }
 
 // Remove a note from storage
@@ -48,7 +48,7 @@ func deleteNote(w http.ResponseWriter, r *http.Request) {
 	}
 	outcome.Success = true
 	outcomeJSON, _ := json.Marshal(outcome)
-	fmt.Fprintf(w, string(outcomeJSON))
+	fmt.Fprint(w, string(outcomeJSON))
 }
 
 // Fetch note content from the database by it's uid.

main.go

@@ -61,7 +61,7 @@ func index(w http.ResponseWriter, r *http.Request) {
 func notFoundHandler(w http.ResponseWriter, req *http.Request) {
 	fmt.Println("Serving:", req.URL, "[404]")
 	w.WriteHeader(http.StatusNotFound)
-	fmt.Fprintf(w, fmt.Sprintf("%d", http.StatusNotFound))
+	fmt.Fprintf(w, "%d", http.StatusNotFound)
 }
 
 func browserCmd(goos string) (string, []string) {