:suspcious-expression should not look into quoted expressions#74
Merged
jafingerhut merged 1 commit intojonase:masterfrom Nov 2, 2014
Merged
:suspcious-expression should not look into quoted expressions#74jafingerhut merged 1 commit intojonase:masterfrom
jafingerhut merged 1 commit intojonase:masterfrom
Conversation
Contributor
Author
|
By the way, here's the sort of thing that caused the original problem: (deftest when-in-quoted-expr |
Collaborator
|
Thanks for the report and suggested fix. I have taken a look at it, and it looks fine, but I will wait to merge it until after I have had a chance to test it on the collection of 50 or so Clojure libraries I use to test Eastwood with. |
jafingerhut
added a commit
that referenced
this pull request
Nov 2, 2014
:suspcious-expression should not look into quoted expressions
jafingerhut
added a commit
that referenced
this pull request
Nov 2, 2014
I already verified before merging the change for #74 that this new test case did cause a :suspicious-expression warning, and as expected that it does not with the change.
Collaborator
|
Steve, thanks for the problem report and the fix. I will probably fix this in a different way in the future that eliminates other undesirable suspicious-expression warnings, but for now I've used your proposed change as is. It is part of Eastwood version 0.1.5, released today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had some data expressions that sort of looked like code which caused spurious warnings from :suspicious-expression. My solution was to avoid linting any form inside a quote. I used the same mechanism that handled 'comment'. Please feel free to refactor as appropriate. I did not study the code too deeply.