Skip to content

Commit b9faaf6

Browse files
[One .NET] built-in Profiled AOT support
Fixes: dotnet#6053 This enables the ability to set: <PropertyGroup Condition=" '$(Configuration)' == 'Release' "> <RunAOTCompilation>true</RunAOTCompilation> <AndroidEnableProfiledAot>true</AndroidEnableProfiledAot> </PropertyGroup> And a default `dotnet.aotprofile` will be passed to the `<MonoAOTCompiler/>` MSBuild task. There will not be a way to "record" profiles in the Android workload in .NET 6. This is because it relies on legacy Mono infrastructure that is not implemented in .NET 6. I created a Github repo for recording profiles, where I committed the necessary binaries such as `aprofutil` and `libmono-profiler-aot.so`: https://github.com/jonathanpeppers/android-profiled-aot I recorded a `dotnet.aotprofile` with the contents: Modules: 6799590C-2963-4835-AEDC-20C67D875132 System.Private.CoreLib 2CC403AF-60DC-48A9-9B69-FF254277AEA0 Mono.Android 92FF7068-2EA9-4681-B340-44E91077417A Java.Interop 008C0F24-5014-4D41-AAB9-DDFCEA59E171 Xamarin.Google.Android.Material 7CEE6098-BE9F-4043-B35A-B8B0684EF0CB Xamarin.AndroidX.AppCompat 20D1FBB8-829A-4618-8E82-8047C8827EA8 Xamarin.AndroidX.Fragment CC363D7A-9CDB-4999-9E10-279412B14A1B Xamarin.AndroidX.Activity 21CF52B7-0256-4838-848C-DA026B2F1789 Xamarin.AndroidX.Core D1DE5607-BC27-45FC-93EC-0542C787E5FF Xamarin.AndroidX.DrawerLayout Summary: Modules: 9 Types: 229 Methods: 1,010 `AndroidApp1` is the `Navigation Drawer App` template from "legacy" Xamarin.Android. I ported this template to .NET 6 and dropped usage of Xamarin.Essentials. I thought this was a good target for a default profile, because of its heavy usage of AndroidX and Google Material. In a future PR, I will add a default AOT profile for .NET MAUI to be shipped inside the `maui` workload. ~~ Results ~~ All tests: 1. Were running on a [Google Pixel 5][0], and 2. Enabled two architectures, arm64 and x86, and 3. **JIT time** was average of 10 runs with `-c Release`, no AOT 4. **AOT time** was average of 10 runs with `-c Release -p:RunAOTCompilation=true`, with the`Activity: Displayed` time 5. **Profiled AOT time** was average of 10 runs with `-c Release -p:RunAOTCompilation=true -p:AndroidEnableProfiledAot=true` with the `Activity: Displayed` time. | Test | JIT time | AOT time | Profiled AOT time | JIT apk size | AOT apk size | Profiled AOT apk size | | ------------------ | ----------: | ----------: | ----------------: | ------------: | ------------: | --------------------: | | [AndroidApp1][1] | 00:00.4387 | 00:00:3317 | 00:00.3093 | 9,155,954 | 12,755,672 | 9,777,880 | | [MauiApp1][2] | 00:01.4205 | 00:00:7285 | 00:00.7098 | 17,435,225 | 44,751,651 | 23,210,787 | [0]: store.google.com/us/product/pixel_5_specs?hl=en-US [1]: jonathanpeppers/android-profiled-aot@e48c6df/AndroidApp1 [2]: jonathanpeppers/android-profiled-aot@e48c6df/MauiApp1
1 parent e9a4c9f commit b9faaf6

File tree

6 files changed

+13
-19
lines changed

6 files changed

+13
-19
lines changed

build-tools/create-packs/Microsoft.Android.Sdk.proj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ core workload SDK packs imported by WorkloadManifest.targets.
7676
<_PackageFiles Include="$(XamarinAndroidSourcePath)src\Xamarin.Android.Build.Tasks\Microsoft.Android.Sdk\Sdk\**" PackagePath="Sdk" />
7777
<_PackageFiles Include="$(XamarinAndroidSourcePath)src\Microsoft.Android.Sdk.ILLink\PreserveLists\**" PackagePath="PreserveLists" />
7878
<_PackageFiles Include="$(XamarinAndroidSourcePath)src\Xamarin.Android.Build.Tasks\Microsoft.Android.Sdk\targets\**" PackagePath="targets" />
79+
<_PackageFiles Include="$(XamarinAndroidSourcePath)src\Xamarin.Android.Build.Tasks\dotnet.aotprofile" PackagePath="targets" />
7980
<_PackageFiles Include="$(IntermediateOutputPath)UnixFilePermissions.xml" PackagePath="data" Condition=" '$(HostOS)' != 'Windows' " />
8081
<None Include="$(MSBuildThisFileDirectory)SignList.xml" CopyToOutputDirectory="PreserveNewest" />
8182
</ItemGroup>

src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.Aot.targets

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,13 @@ They run in a context of an inner build with a single $(RuntimeIdentifier).
6969
TempDirectory="$([MSBuild]::EnsureTrailingSlash($(_AotOutputDirectory)))%(FileName)"
7070
AotArguments="$(_AotArguments),temp-path=$([System.IO.Path]::GetFullPath(%(_MonoAOTAssemblies.TempDirectory)))"
7171
/>
72+
<AndroidAotProfile Include="$(MSBuildThisFileDirectory)dotnet.aotprofile" Condition=" '$(AndroidEnableProfiledAot)' == 'true' and '$(AndroidUseDefaultAotProfile)' != 'false' " />
7273
</ItemGroup>
7374
<MakeDir Directories="$(IntermediateOutputPath)aot\;@(_MonoAOTAssemblies->'%(TempDirectory)')" />
7475
<MonoAOTCompiler
7576
Assemblies="@(_MonoAOTAssemblies)"
7677
CompilerBinaryPath="$(_MonoAOTCompilerPath)"
78+
AotProfilePath="@(AndroidAotProfile->'%(FullPath)')"
7779
DisableParallelAot="$(_DisableParallelAot)"
7880
LibraryFormat="So"
7981
Mode="$(AndroidAotMode)"

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Application.targets

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ Copyright (C) 2019 Microsoft Corporation. All rights reserved.
4848
DependsOnTargets="$(_BeginAotProfilingDependsOnTargets)">
4949
</Target>
5050
<Target Name="FinishAotProfiling"
51-
DependsOnTargets="_ResolveSdks">
51+
DependsOnTargets="_ResolveSdks;_ResolveMonoAndroidSdks">
5252
<Exec Command="&quot;$(AdbToolPath)adb&quot; $(AdbTarget) forward tcp:$(AndroidAotProfilerPort) tcp:$(AndroidAotProfilerPort)" />
53-
<Exec Command="&quot;$(MonoAndroidBinDirectory)aprofutil&quot; $(AProfUtilExtraOptions) -s -v -p $(AndroidAotProfilerPort) -o &quot;$(AndroidAotCustomProfilePath)&quot;" />
53+
<Exec Command="&quot;$(AProfUtilToolPath)aprofutil&quot; $(AProfUtilExtraOptions) -s -v -p $(AndroidAotProfilerPort) -o &quot;$(AndroidAotCustomProfilePath)&quot;" />
5454
</Target>
5555
</Project>

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -680,6 +680,12 @@ because xbuild doesn't support framework reference assemblies.
680680
/>
681681
</CreateProperty>
682682

683+
<CreateProperty Value="$(MonoAndroidBinDirectory)">
684+
<Output TaskParameter="Value" PropertyName="AProfUtilToolPath"
685+
Condition="'$(AProfUtilToolPath)' == ''"
686+
/>
687+
</CreateProperty>
688+
683689
<CreateProperty Value="--dex --no-strict">
684690
<Output TaskParameter="Value" PropertyName="DxExtraArguments"
685691
Condition="'$(DxExtraArguments)' == ''"
Binary file not shown.

src/monodroid/jni/monodroid-glue.cc

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1567,7 +1567,6 @@ MonodroidRuntime::set_trace_options (void)
15671567
mono_jit_set_trace_options (value.get ());
15681568
}
15691569

1570-
#if defined (NET6)
15711570
inline void
15721571
MonodroidRuntime::set_profile_options ()
15731572
{
@@ -1582,23 +1581,10 @@ MonodroidRuntime::set_profile_options ()
15821581
value.assign (prop_value);
15831582
}
15841583

1584+
#if defined (NET6)
15851585
// setenv(3) makes copies of its arguments
15861586
setenv ("DOTNET_DiagnosticPorts", value.get (), 1);
1587-
}
1588-
#else // def NET6
1589-
inline void
1590-
MonodroidRuntime::set_profile_options ()
1591-
{
1592-
// We want to avoid dynamic allocation, thus let’s create a buffer that can take both the property value and a
1593-
// path without allocation
1594-
dynamic_local_string<SENSIBLE_PATH_MAX + PROPERTY_VALUE_BUFFER_LEN> value;
1595-
{
1596-
dynamic_local_string<PROPERTY_VALUE_BUFFER_LEN> prop_value;
1597-
if (androidSystem.monodroid_get_system_property (Debug::DEBUG_MONO_PROFILE_PROPERTY, prop_value) == 0)
1598-
return;
1599-
1600-
value.assign (prop_value.get (), prop_value.length ());
1601-
}
1587+
#endif // def NET6
16021588

16031589
constexpr char OUTPUT_ARG[] = "output=";
16041590
constexpr size_t OUTPUT_ARG_LEN = sizeof(OUTPUT_ARG) - 1;
@@ -1673,7 +1659,6 @@ MonodroidRuntime::set_profile_options ()
16731659
log_warn (LOG_DEFAULT, "Initializing profiler with options: %s", value.get ());
16741660
debug.monodroid_profiler_load (androidSystem.get_runtime_libdir (), value.get (), output_path.get ());
16751661
}
1676-
#endif // ndef NET6
16771662

16781663
/*
16791664
Disable LLVM signal handlers.

0 commit comments

Comments
 (0)