Skip to content

Commit d10a7db

Browse files
committed
Allow changes to "runner_worker.max_jobs" for Docker Autoscaler
Remove ignore_changes from the ASG for Docker Autoscaler. The reasoning described in the comment was poor; min_size and desired_capacity are fixed at zero, so won't change, and max_size should change when runner_worker.max_jobs is changed, and will not cause immediate scale-up. If it causes scale-down, this the logical desired behaviour.
1 parent bfe4387 commit d10a7db

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

docker_autoscaler.tf

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -187,13 +187,4 @@ resource "aws_autoscaling_group" "autoscaler" {
187187
propagate_at_launch = true
188188
}
189189
}
190-
191-
lifecycle {
192-
# do not change these values as we would immediately scale up/down, which is not wanted
193-
ignore_changes = [
194-
desired_capacity,
195-
min_size,
196-
max_size
197-
]
198-
}
199190
}

0 commit comments

Comments
 (0)