Skip to content

Commit d1ba19a

Browse files
committed
Add the list of issues fixed by the new marker implementation to the docs
This will help make users more understanding if their code breaks under the new implementation.
1 parent 2241c98 commit d1ba19a

File tree

1 file changed

+29
-0
lines changed

1 file changed

+29
-0
lines changed

doc/en/mark.rst

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,35 @@ in fact, markers where only accessible in functions, even if they where declared
5151

5252
A new API to access markers has been introduced in pytest 3.6 in order to solve the problems with the initial design, providing :func:`_pytest.nodes.Node.iter_markers` method to iterate over markers in a consistent manner and reworking the internals, which solved great deal of problems with the initial design.
5353

54+
Here is a non-exhaustive list of issues fixed by the new implementation:
55+
56+
57+
* Marks don't pick up nested classes (`#199 <https://github.com/pytest-dev/pytest/issues/199>`_).
58+
59+
* markers stains on all related classes (`#568 <https://github.com/pytest-dev/pytest/issues/568>`_).
60+
61+
* combining marks - args and kwargs calculation (`#2897 <https://github.com/pytest-dev/pytest/issues/2897>`_).
62+
63+
* ``request.node.get_marker('name')`` returns ``None`` for markers applied in classes (`#902 <https://github.com/pytest-dev/pytest/issues/902>`_).
64+
65+
* marks applied in parametrize are stored as markdecorator (`#2400 <https://github.com/pytest-dev/pytest/issues/2400>`_).
66+
67+
* fix marker interaction in a backward incompatible way (`#1670 <https://github.com/pytest-dev/pytest/issues/1670>`_).
68+
69+
* Refactor marks to get rid of the current "marks transfer" mechanism (`#2363 <https://github.com/pytest-dev/pytest/issues/2363>`_).
70+
71+
* Introduce FunctionDefinition node, use it in generate_tests (`#2522 <https://github.com/pytest-dev/pytest/issues/2522>`_).
72+
73+
* remove named marker attributes and collect markers in items (`#891 <https://github.com/pytest-dev/pytest/issues/891>`_).
74+
75+
* skipif mark from parametrize hides module level skipif mark (`#1540 <https://github.com/pytest-dev/pytest/issues/1540>`_).
76+
77+
* skipif + parametrize not skipping tests (`#1296 <https://github.com/pytest-dev/pytest/issues/1296>`_).
78+
79+
* marker transfer incompatible with inheritance (`#535 <https://github.com/pytest-dev/pytest/issues/535>`_).
80+
81+
More details can be found in the `original PR <https://github.com/pytest-dev/pytest/pull/3317>`_.
82+
5483
.. note::
5584

5685
in a future major relase of pytest we will introduce class based markers,

0 commit comments

Comments
 (0)