[tests] Use emulator -logcat-output to capture device state (dotnet#6432)

Sometimes unit tests will fail, because the emulator failed to start:

	Task "StartAndroidEmulator"
	  …
	  Tool /Users/runner/Library/Android/sdk/emulator/emulator execution started with arguments:  -verbose -no-boot-anim -no-audio -no-snapshot -cache-size 512 -timezone "Etc/UTC" -avd XamarinAndroidTestRunner29-x86_64 -port 5570
	  …
	  [emulator stderr] handleCpuAcceleration: feature check for hvf
	…
	Task "Xamarin.Android.Tools.BootstrapTasks.Adb"
	  …
	  Executing: /Users/runner/Library/Android/sdk/platform-tools/adb -s emulator-5570 wait-for-device
	  …
	/Users/runner/work/1/s/build-tools/scripts/TestApks.targets(78,5): error :   Command /Users/runner/Library/Android/sdk/platform-tools/adb -s emulator-5570 wait-for-device failed with exit code -1 [/Users/runner/work/1/s/tests/Mono.Android-Tests/Mono.Android-Tests.csproj]
	Done executing task "Xamarin.Android.Tools.BootstrapTasks.Adb" -- FAILED.
	Done building target "AcquireAndroidTarget" in project "Mono.Android-Tests.csproj" -- FAILED.

What's happening is that `adb wait-for-device` is timing out after
2 minutes, at which point we give up.

We don't know *why* `adb wait-for-device` is timing out.  We have no
additional information to investigate.

Update the `<StartAndroidEmulator/>` task to have a
`StartAndroidEmulator.LogcatFile` property, which is used with the
`emulator -logcat-output` option.  This allows us to capture *all*
output that `adb logcat` would provide, including during emulator
startup.  This should allow us to further diagnose *why* the emulator
is "hanging" during `adb wait-for-exit`.

Store the full `adb logcat` output into the file
`bin/Test$(Configuration)/logcat-$(Configuration)-full.log`.
This file will be included in the test `xa-build-status*` zip
archives which are saved at the end of a test run.

Additionally, fix a bug in the `DeviceTest.RestartDevice()` method
where it could fail when using `dotnet`:

	RunProcess: /Users/runner/Library/Android/dotnet/dotnet /Users/runner/work/1/s/bin/TestRelease/Emulator.csproj /restore /t:AcquireAndroidTarget
	(1, , Could not execute because the specified command or file was not found.

We need to be using `dotnet build /path/to/proj.csproj`.

Author: dellis1972

build-tools/Xamarin.Android.Tools.BootstrapTasks/Xamarin.Android.Tools.BootstrapTasks/KillProcess.cs

@@ -19,7 +19,8 @@ public override bool Execute()
 			Log.LogMessage(MessageImportance.Low, $"  {nameof (ProcessId)}: {ProcessId}");
 
 			using (var p = Process.GetProcessById (ProcessId)) {
-				p.Kill ();
+				if (!p.HasExited)
+					p.Kill ();
 			}
 
 			return !Log.HasLoggedErrors;

build-tools/Xamarin.Android.Tools.BootstrapTasks/Xamarin.Android.Tools.BootstrapTasks/StartAndroidEmulator.cs

@@ -33,6 +33,7 @@ public class StartAndroidEmulator : Task
 		public			string		Arguments	{get; set;}
 		public                  string          ToolPath        {get; set;}
 		public                  string          ToolExe         {get; set;}
+		public                  string          LogcatFile      {get; set;}
 
 		public override bool Execute ()
 		{
@@ -68,7 +69,7 @@ void Run (string emulator)
 				return;
 
 			var port = string.IsNullOrEmpty (Port) ? "" : $" -port {Port}";
-			var arguments = $"{Arguments ?? string.Empty} -verbose -no-boot-anim -no-audio -no-snapshot -cache-size 512 -timezone \"Etc/UTC\" -avd {ImageName}{port}";
+			var arguments = $"{Arguments ?? string.Empty} -verbose -logcat-output \"{LogcatFile}\" -no-boot-anim -no-audio -no-snapshot -cache-size 512 -timezone \"Etc/UTC\" -avd {ImageName}{port}";
 			Log.LogMessage (MessageImportance.Low, $"Tool {emulator} execution started with arguments: {arguments}");
 			var psi = new ProcessStartInfo () {
 				FileName                = emulator,

build-tools/scripts/TestApks.targets

@@ -26,6 +26,7 @@
     <AvdLaunchTimeoutMinutes Condition=" '$(AvdLaunchTimeoutMinutes)' == '' ">5</AvdLaunchTimeoutMinutes>
     <AvdLaunchTimeoutSeconds>$([MSBuild]::Multiply($(AvdLaunchTimeoutMinutes), 60))</AvdLaunchTimeoutSeconds>
     <AvdLaunchTimeoutMS>$([MSBuild]::Multiply($(AvdLaunchTimeoutSeconds), 1000))</AvdLaunchTimeoutMS>
+    <_LogcatFilename>$(MSBuildThisFileDirectory)..\..\bin\Test$(Configuration)\logcat-$(Configuration)-full.log</_LogcatFilename>
   </PropertyGroup>
 
   <ItemGroup>
@@ -68,6 +69,7 @@
         AvdManagerHome="$(AvdManagerHome)"
         Arguments="$(TestEmulatorArguments)"
         ImageName="$(TestAvdName)"
+        LogcatFile="$(_LogcatFilename)"
         Port="$(_AdbEmulatorPort)"
         ToolExe="$(EmulatorToolExe)"
         ToolPath="$(EmulatorToolPath)">

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/DeviceTest.cs

@@ -104,7 +104,7 @@ public static void RestartDevice (string project)
 			TestContext.Out.WriteLine ($"Trying to restart Emulator");
 			// shell out to msbuild and start the emulator again
 			using (var builder = new Builder ()) {
-				var out1 = RunProcessWithExitCode (builder.BuildTool, $"{project} /restore /t:AcquireAndroidTarget", timeoutInSeconds: 120);
+				var out1 = RunProcessWithExitCode (builder.BuildTool, $"{(Builder.UseDotNet ? "build" : "")} {project} /restore /t:AcquireAndroidTarget", timeoutInSeconds: 120);
 				TestContext.Out.WriteLine ($"{out1}");
 			}
 		}