Skip to content

Commit 518e57c

Browse files
authored
Bump to Java.Interop/master/5eeb287b (dotnet#546)
Commits prior to Java.Interop/5eeb287b had a bug in `Xamarin.Android.Cecil.csproj` which would cause it to constantly generate new assemblies whenever it was built. The result being that: xbuild src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj would *always* take a lengthy amount of time -- ~36 seconds -- even when "nothing has changed." In fact, something *had* changed: `Xamarin.Android.Cecil.dll` had changed, necessitating that *every project that references it* also be rebuilt, in a cascading manner: Target CoreCompile needs to be built as input file '.../xamarin-android/external/Java.Interop/bin/Debug//Xamarin.Android.Cecil.dll' is newer than output file 'obj/Debug/Xamarin.Android.Tools.Aidl.dll' Target CoreCompile needs to be built as input file '.../xamarin-android/external/Java.Interop/bin/Debug//Xamarin.Android.Cecil.dll' is newer than output file 'obj/Debug/Java.Interop.Tools.Diagnostics.dll' Target CoreCompile needs to be built as input file '.../xamarin-android/external/Java.Interop/bin/Debug//Java.Interop.Tools.Diagnostics.dll' is newer than output file 'obj/Debug/Java.Interop.Tools.Cecil.dll' Target CoreCompile needs to be built as input file '.../xamarin-android/external/Java.Interop/bin/Debug//Java.Interop.Tools.Cecil.dll' is newer than output file 'obj/Debug/Java.Interop.Tools.JavaCallableWrappers.dll' Target CoreCompile needs to be built as input file '.../xamarin-android/external/Java.Interop/bin/Debug//Xamarin.Android.Cecil.dll' is newer than output file 'obj/Debug/generator.exe' Target CoreCompile needs to be built as input file '.../xamarin-android/external/Java.Interop/bin/Debug//Xamarin.Android.Cecil.dll' is newer than output file 'obj/Debug/jcw-gen.exe' Target CoreCompile needs to be built as input file '.../xamarin-android/external/Java.Interop/bin/Debug//Xamarin.Android.Cecil.dll' is newer than output file 'obj/Debug/remap-assembly-ref.exe' Target _BuildJNIEnv needs to be built as input file '../../bin/BuildDebug/jnienv-gen.exe' is newer than output file 'Android.Runtime/JNIEnv.g.cs' Target _GenerateMonoAndroidDex18 needs to be built as input file '../../bin/Debug/lib/xbuild-frameworks/MonoAndroid/v7.1/mono.android.jar' is newer than output file '../../bin/Debug/lib/xbuild-frameworks/MonoAndroid/v7.1/mono.android.dex' Target CoreCompile needs to be built as input file 'obj/Debug/Profile.g.cs' is newer than output file 'obj/Debug/Xamarin.Android.Build.Tasks.dll' This is maddening, and serves no purpose. Java.Interop/5eeb287b fixed `Xamarin.Android.Cecil.csproj` so that it wouldn't constantly regenerate the output assembly, which should help improve the cascading rebuild situation.
1 parent fb534d6 commit 518e57c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

external/Java.Interop

0 commit comments

Comments
 (0)