fix(#82): make the framework update action work (#154)

Author: nishantwrp

.github/workflows/cd.yml

@@ -20,7 +20,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 24
       - name: Install dependencies
         run: npm install --legacy-peer-deps
       - name: Build plugin

.github/workflows/ci.yml

@@ -17,7 +17,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 24
       - name: Install dependencies
         run: npm install --legacy-peer-deps
       - name: Run check
@@ -31,7 +31,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 24
       - name: Install dependencies
         run: npm install --legacy-peer-deps
       - name: Run check
@@ -45,7 +45,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 24
       - name: Install dependencies
         run: npm install --legacy-peer-deps
       - name: Run check

.github/workflows/coverage.yml

@@ -18,7 +18,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 24
       - name: Install dependencies
         run: npm install --legacy-peer-deps
       - name: Generage coverage report

.github/workflows/update-framework.yml

@@ -11,23 +11,30 @@ permissions:
 
 jobs:
   update-framework:
-    runs-on: ubuntu-latest
-    
+    runs-on: ubuntu-latest    
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
-      
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
-      
+          node-version: 24
       - name: Install generator-joplin globally
         run: npm install -g generator-joplin yo
-      
       - name: Run framework update
-        run: yo joplin --update --silent
-      
+        run: yo joplin --update --silent --force --skip-install
+      - name: New tsconfig.json content
+        id: new-tsconfig-json
+        run: |
+          {
+            echo 'content<<EOF'
+            sed -e '$a\' tsconfig.json
+            echo EOF
+          } >> "$GITHUB_OUTPUT"
+      - name: Revert tsconfig.json
+        run: |
+          git checkout -- tsconfig.json
+      # Just tsconfig.json changes would not be important anyways
       - name: Check for changes
         id: changes
         run: |
@@ -36,24 +43,23 @@ jobs:
           else
             echo "has_changes=true" >> $GITHUB_OUTPUT
           fi
-      
-      - name: Install dependencies
-        run: npm install --legacy-peer-deps
-      
       - name: Create Pull Request
         if: steps.changes.outputs.has_changes == 'true'
         uses: peter-evans/create-pull-request@v6
         with:
-          commit-message: 'chore: monthly joplin plugin framework update'
-          title: 'chore: update joplin plugin framework (automated)'
+          commit-message: 'chore: routine joplin plugin framework update'
+          title: 'chore: routine joplin plugin framework update'
           body: |
-            This is an automated pull request to update the Joplin plugin framework.
-            
-            Please review the changes and ensure:
-            - All tests pass
-            - Build succeeds
-            - No breaking changes introduced
+            This is an automated pull request to update the joplin plugin framework.
+
+            ## Some files were not updated from the framework
+
+            ### tsconfig.json
+            ```json
+            ${{ steps.new-tsconfig-json.outputs.content }}
+            ```
           branch: chore/update-plugin-framework
           branch-suffix: timestamp
+          committer: Albus <bot@nishantwrp.com>
+          author: Albus <bot@nishantwrp.com>
           delete-branch: true
-          labels: dependencies, automated

.npmrc

@@ -0,0 +1 @@
+node-options=--openssl-legacy-provider