Skip to content

fix: run framework update non-interactively in CI#148

Merged
nishantwrp merged 3 commits intojoplin:masterfrom
Aaravanand00:fix/framework-update-ci
Mar 3, 2026
Merged

fix: run framework update non-interactively in CI#148
nishantwrp merged 3 commits intojoplin:masterfrom
Aaravanand00:fix/framework-update-ci

Conversation

@Aaravanand00
Copy link
Copy Markdown
Contributor

The framework update command was running interactively and waiting for confirmation in CI.

This change runs it non-interactively by piping y into the command so the workflow can complete successfully.

Copy link
Copy Markdown
Collaborator

@nishantwrp nishantwrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ptal at comments here #147 (comment)

@Aaravanand00
Copy link
Copy Markdown
Contributor Author

Hi @nishantwrp,

I’ve updated the workflow as suggested.

  • Replaced the interactive command with yo joplin --update --silent.

  • Moved the “Check for changes” step to run right after the framework update
    step, before npm install

This should address both issues. Please take a look is this ok?

@nishantwrp nishantwrp merged commit c627d13 into joplin:master Mar 3, 2026
3 checks passed
@nishantwrp
Copy link
Copy Markdown
Collaborator

Hi @Aaravanand00, the workflow still doesn't run correctly. https://github.com/joplin/plugin-templates/actions/runs/22628514766/job/65571690685

Can you please fix? Also, please test your changes locally as well before raising a pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants