fix: run framework update non-interactively in CI#148
Merged
nishantwrp merged 3 commits intojoplin:masterfrom Mar 3, 2026
Merged
fix: run framework update non-interactively in CI#148nishantwrp merged 3 commits intojoplin:masterfrom
nishantwrp merged 3 commits intojoplin:masterfrom
Conversation
nishantwrp
requested changes
Mar 2, 2026
Collaborator
nishantwrp
left a comment
There was a problem hiding this comment.
ptal at comments here #147 (comment)
Contributor
Author
|
Hi @nishantwrp, I’ve updated the workflow as suggested.
This should address both issues. Please take a look is this ok? |
nishantwrp
approved these changes
Mar 3, 2026
Collaborator
|
Hi @Aaravanand00, the workflow still doesn't run correctly. https://github.com/joplin/plugin-templates/actions/runs/22628514766/job/65571690685 Can you please fix? Also, please test your changes locally as well before raising a pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The framework update command was running interactively and waiting for confirmation in CI.
This change runs it non-interactively by piping
yinto the command so the workflow can complete successfully.