Fix microsoft#106303

roblourens · roblourens · commit 8e5eed12991c · 2020-09-09T21:44:43.000-05:00
diff --git a/src/vs/workbench/contrib/preferences/browser/settingsEditor2.ts b/src/vs/workbench/contrib/preferences/browser/settingsEditor2.ts
@@ -343,7 +343,10 @@ export class SettingsEditor2 extends EditorPane {
 		super.setEditorVisible(visible, group);
 
 		if (!visible) {
-			this.searchWidget.onHide();
+			// Wait for editor to be removed from DOM #106303
+			process.nextTick(() => {
+				this.searchWidget.onHide();
+			});
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -343,7 +343,10 @@ export class SettingsEditor2 extends EditorPane {`
`343`	`343`	`super.setEditorVisible(visible, group);`
`344`	`344`
`345`	`345`	`if (!visible) {`
`346`		`- this.searchWidget.onHide();`
	`346`	`+ // Wait for editor to be removed from DOM #106303`
	`347`	`+ process.nextTick(() => {`
	`348`	`+ this.searchWidget.onHide();`
	`349`	`+ });`
`347`	`350`	`}`
`348`	`351`	`}`
`349`	`352`