Skip to content

Broken in IE10/11 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jhildenbiddle opened this issue Apr 15, 2018 · 1 comment
Closed

Broken in IE10/11 #1

jhildenbiddle opened this issue Apr 15, 2018 · 1 comment

Comments

@jhildenbiddle
Copy link
Collaborator

jhildenbiddle commented Apr 15, 2018

Two issues:

var codeBlocks = document.querySelectorAll("pre[v-pre]");
codeBlocks.forEach((element, i, obj) => {

  1. querySelectorAll returns a NodeList, and not all browsers provide a forEach method on NodeLists.

  2. Arrow functions are not support in IE (or older evergreen browsers).

Fixed by #3

@jperasmus
Copy link
Owner

Hi @jhildenbiddle, thanks for your contributions, it is much appreciated! I originally put this plugin together quickly for a specific use case we had targeting developers specifically on modern browsers. Thanks for your efforts to improve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants