Uses .toList() instead of .collect(Collectors.toList()) wherever possible

Author: jqno

equalsverifier-core/src/main/java/nl/jqno/equalsverifier/api/MultipleTypeEqualsVerifierApi.java

@@ -106,8 +106,7 @@ public MultipleTypeEqualsVerifierApi withFieldnameToGetterConverter(Function<Str
      * @since 0.1
      */
     public void verify() {
-        List<EqualsVerifierReport> failures =
-                report().stream().filter(r -> !r.isSuccessful()).collect(Collectors.toList());
+        List<EqualsVerifierReport> failures = report().stream().filter(r -> !r.isSuccessful()).toList();
         if (failures.isEmpty()) {
             return;
         }
@@ -133,6 +132,6 @@ public void verify() {
      * @since 3.0
      */
     public List<EqualsVerifierReport> report() {
-        return types.stream().map(t -> ev.forClass(t).report(false)).collect(Collectors.toList());
+        return types.stream().map(t -> ev.forClass(t).report(false)).toList();
     }
 }

equalsverifier-core/src/main/java/nl/jqno/equalsverifier/internal/instantiation/vintage/reflection/RecordObjectAccessor.java

@@ -3,7 +3,6 @@
 import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.function.Function;
-import java.util.stream.Collectors;
 
 import nl.jqno.equalsverifier.internal.instantiation.vintage.VintageValueProvider;
 import nl.jqno.equalsverifier.internal.reflection.FieldProbe;
@@ -30,7 +29,7 @@ final class RecordObjectAccessor<T> extends ObjectAccessor<T> {
     /** {@inheritDoc} */
     @Override
     public T copy(Objenesis objenesis) {
-        List<?> params = probe.fields().map(this::getField).collect(Collectors.toList());
+        List<?> params = probe.fields().map(this::getField).toList();
         return callRecordConstructor(params);
     }
 
@@ -49,7 +48,7 @@ public ObjectAccessor<T> scramble(
     }
 
     private ObjectAccessor<T> makeAccessor(Function<FieldProbe, Object> determineValue) {
-        List<Object> params = probe.fields().map(determineValue).collect(Collectors.toList());
+        List<Object> params = probe.fields().map(determineValue).toList();
         T newObject = callRecordConstructor(params);
         return ObjectAccessor.of(newObject);
     }

equalsverifier-core/src/main/java/nl/jqno/equalsverifier/internal/reflection/FieldIterable.java

@@ -117,7 +117,7 @@ private List<FieldProbe> createKotlinFieldList() {
         if (includeSuperclasses) {
             for (Class<?> c : SuperclassIterable.of(type)) {
                 List<FieldProbe> superFields =
-                        addFieldsFor(c).stream().filter(p -> !names.contains(p.getName())).collect(Collectors.toList());
+                        addFieldsFor(c).stream().filter(p -> !names.contains(p.getName())).toList();
                 result.addAll(superFields);
                 superFields.stream().map(FieldProbe::getName).forEach(names::add);
             }

equalsverifier-core/src/main/java/nl/jqno/equalsverifier/internal/reflection/PackageScanner.java

@@ -44,11 +44,7 @@ private static List<File> getDirs(String packageName, PackageScanOptions options
         ClassLoader cl = Thread.currentThread().getContextClassLoader();
         String path = packageName.replace('.', '/');
         return rethrow(
-            () -> Collections
-                    .list(cl.getResources(path))
-                    .stream()
-                    .flatMap(r -> getResourcePath(r, options))
-                    .collect(Collectors.toList()),
+            () -> Collections.list(cl.getResources(path)).stream().flatMap(r -> getResourcePath(r, options)).toList(),
             e -> "Could not scan package " + packageName);
     }
 
@@ -86,7 +82,7 @@ private static List<Class<?>> getClassesInDir(String packageName, File dir, Pack
                 .filter(
                     c -> options.mustExtend() == null
                             || (options.mustExtend().isAssignableFrom(c) && !options.mustExtend().equals(c)))
-                .collect(Collectors.toList());
+                .toList();
     }
 
     private static Class<?> fileToClass(String packageName, File file) {

equalsverifier-core/src/main/java/nl/jqno/equalsverifier/internal/util/Validations.java

@@ -209,7 +209,7 @@ public static void validatePackageContainsClasses(String packageName, List<Class
     }
 
     public static void validateTypesAreKnown(Collection<Class<?>> types, List<Class<?>> knownTypes) {
-        List<Class<?>> unknownTypes = types.stream().filter(t -> !knownTypes.contains(t)).collect(Collectors.toList());
+        List<Class<?>> unknownTypes = types.stream().filter(t -> !knownTypes.contains(t)).toList();
         String message = "Unknown class(es) found: "
                 + unknownTypes.stream().map(t -> t.getCanonicalName()).collect(Collectors.joining(", "));
         validate(!unknownTypes.isEmpty(), message);

equalsverifier-core/src/test/java/nl/jqno/equalsverifier/internal/reflection/PackageScannerTest.java

@@ -4,7 +4,6 @@
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
 import java.util.*;
-import java.util.stream.Collectors;
 
 import nl.jqno.equalsverifier.ScanOption;
 import nl.jqno.equalsverifier.internal.exceptions.ReflectionException;
@@ -96,8 +95,7 @@ void happyPathExceptPredicate() {
     @Test
     void filterOutTestClasses() {
         List<Class<?>> classes = PackageScanner.getClassesIn("nl.jqno.equalsverifier.internal.reflection", opts);
-        List<Class<?>> testClasses =
-                classes.stream().filter(c -> c.getName().endsWith("Test")).collect(Collectors.toList());
+        List<Class<?>> testClasses = classes.stream().filter(c -> c.getName().endsWith("Test")).toList();
         assertThat(testClasses).isEqualTo(Collections.emptyList());
         assertThat(classes.size() - testClasses.size() > 0).isTrue();
     }
@@ -106,8 +104,7 @@ void filterOutTestClasses() {
     void filterOutTestClassesRecursively() {
         opts = PackageScanOptions.process(ScanOption.recursive());
         List<Class<?>> classes = PackageScanner.getClassesIn("nl.jqno.equalsverifier.internal.reflection", opts);
-        List<Class<?>> testClasses =
-                classes.stream().filter(c -> c.getName().endsWith("Test")).collect(Collectors.toList());
+        List<Class<?>> testClasses = classes.stream().filter(c -> c.getName().endsWith("Test")).toList();
         assertThat(testClasses).isEqualTo(Collections.emptyList());
         assertThat(classes.size() - testClasses.size() > 0).isTrue();
     }