Skip to content
This repository was archived by the owner on Jun 2, 2023. It is now read-only.

Operators highlighting #26

Closed
cosmo0 opened this issue Nov 24, 2014 · 6 comments
Closed

Operators highlighting #26

cosmo0 opened this issue Nov 24, 2014 · 6 comments

Comments

@cosmo0
Copy link

cosmo0 commented Nov 24, 2014

Hi !

There is a problem with the operators highlighting: when I run a custom method with a parameter which name starts with a global operator name, only the start of the parameter is highlighted. For instance, My-Method -equal "test" will highlight the "eq" part of the "equal" parameter.

There is another problem as well, but I'm guessing it's harder to fix. For instance I'm using a -from and a -to parameters, the -from is highlighted (because it's a keyword), but not the -to.

@jrsconfitto
Copy link
Owner

Thanks for the report! i'll take a look into it soon.

i've been wanting to clean up the way parameters are highlighted in the language (#24) and i think that i can clean this up along the way.

@cosmo0
Copy link
Author

cosmo0 commented Nov 24, 2014

Thanks ! :) That's be great :)

@jrsconfitto
Copy link
Owner

OK, i'm publishing a fix as we speak. i didn't quite get to the stuff in your -to/-from report yet as that's wrapped up in issue #24. So i'm going to close this out. Feel free to reopen if you think i'm missing (or missed) something.

Thanks again for the input 😄

@jrsconfitto
Copy link
Owner

as we speak

Weird phrase to use in an internet comment 😝

@cosmo0
Copy link
Author

cosmo0 commented Nov 26, 2014

It fixed the -eqsomething problem 😃

For the from/to problem: I have a method that I call like that:

Install-ConfigFiles -from "$here\tests\process" -to "$here"

The -from is highlighted, but the -to is white. With my color scheme (Monokai), -from is pink and -to is white.

By the way, that makes me think of another problem: the pass word is differently highlighted (with a pink background, with my theme) than the rest. It's the only word I found that has this highlight style. Even when it's "part of a chain" (like $ProcessConfig.ftp.pass) it's highlighted.

Thank you for your hard work 😄
I don't even use a Powershell editor like PowerGUI anymore since I found out about atom+your syntax 😄

@jrsconfitto
Copy link
Owner

Thanks for that. i'll add the first stuff to #24 and i'll create a new issue for the pass thing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants