Add new setter tests

Author: domenic

scripts/get-latest-platform-tests.js

@@ -15,11 +15,15 @@ const request = require("request");
 // 1. Go to https://github.com/w3c/web-platform-tests/blob/master/url/urltestdata.json
 // 2. Press "y" on your keyboard to get a permalink
 // 3. Copy the commit hash
-const commitHash = "a8e267d32ff41ee2963e4ad6d8f4af5bdd414595";
+const commitHash = "7d202a76b90fccb246c6aaee42fa5b251e2f649e";
 
 const sourceURL = `https://raw.githubusercontent.com/w3c/web-platform-tests/${commitHash}/url/urltestdata.json`;
+const setterSourceURL = `https://raw.githubusercontent.com/w3c/web-platform-tests/${commitHash}/url/setters_tests.json`;
 
 const targetDir = path.resolve(__dirname, "..", "test", "web-platform-tests");
 
 request.get(sourceURL)
   .pipe(fs.createWriteStream(path.resolve(targetDir, "urltestdata.json")));
+
+request.get(setterSourceURL)
+  .pipe(fs.createWriteStream(path.resolve(targetDir, "setters_tests.json")));

test/web-platform.js

@@ -1,8 +1,9 @@
 "use strict";
 const assert = require("assert");
 const URL = require("..").URL;
-const testCases = require("./web-platform-tests/urltestdata.json");
-const additionalTestCases = require("./to-upstream.json");
+const parsingTestCases = require("./web-platform-tests/urltestdata.json");
+const additionalParsingTestCases = require("./to-upstream.json");
+const setterTestData = require("./web-platform-tests/setters_tests.json");
 
 function testURL(expected) {
   return () => {
@@ -32,24 +33,49 @@ function testURL(expected) {
   };
 }
 
-describe("Web Platform Tests", () => {
-  for (const expected of testCases) {
+function testSetterCase(testCase, propertyName) {
+  return () => {
+    const url = new URL(testCase.href);
+    url[propertyName] = testCase.new_value;
+
+    for (const expectedProperty in testCase.expected) {
+      assert.equal(url[expectedProperty], testCase.expected[expectedProperty]);
+    }
+  };
+}
+
+describe("Web Platform Tests: parsing", () => {
+  for (const expected of parsingTestCases) {
     if (typeof expected === "string") {
       // It's a "comment"; skip it.
       continue;
     }
 
-    it("Parsing: <" + expected.input + "> against <" + expected.base + ">", testURL(expected));
+    specify(`<${expected.input}> against <${expected.base}>`, testURL(expected));
+  }
+});
+
+describe("Web Platform Tests: setters", () => {
+  for (const key of Object.keys(setterTestData)) {
+    if (key === "comment") {
+      continue;
+    }
+
+    describe(key, () => {
+      for (const testCase of setterTestData[key]) {
+        specify(`<${testCase.href}>.${key} = "${testCase.new_value}" ${testCase.comment || ""}`, testSetterCase(testCase, key));
+      }
+    });
   }
 });
 
-describe("To-upstream tests", () => {
-  for (const expected of additionalTestCases) {
+describe("To-upstream tests: parsing", () => {
+  for (const expected of additionalParsingTestCases) {
     if (typeof expected === "string") {
       // It's a "comment"; skip it.
       continue;
     }
 
-    it("Parsing: <" + expected.input + "> against <" + expected.base + ">", testURL(expected));
+    specify("<" + expected.input + "> against <" + expected.base + ">", testURL(expected));
   }
 });