Fixed naming conventions

Resharper was set to auto-detect, making it ignore configured rules

Author: Bart Koelman

benchmarks/Serialization/JsonApiDeserializerBenchmarks.cs

@@ -15,7 +15,7 @@ namespace Benchmarks.Serialization
     [MarkdownExporter]
     public class JsonApiDeserializerBenchmarks
     {
-        private static readonly string _content = JsonConvert.SerializeObject(new Document
+        private static readonly string Content = JsonConvert.SerializeObject(new Document
         {
             Data = new ResourceObject
             {
@@ -43,6 +43,6 @@ public JsonApiDeserializerBenchmarks()
         }
 
         [Benchmark]
-        public object DeserializeSimpleObject() => _jsonApiDeserializer.Deserialize(_content);
+        public object DeserializeSimpleObject() => _jsonApiDeserializer.Deserialize(Content);
     }
 }

benchmarks/Serialization/JsonApiSerializerBenchmarks.cs

@@ -14,7 +14,7 @@ namespace Benchmarks.Serialization
     [MarkdownExporter]
     public class JsonApiSerializerBenchmarks
     {
-        private static readonly BenchmarkResource _content = new BenchmarkResource
+        private static readonly BenchmarkResource Content = new BenchmarkResource
         {
             Id = 123,
             Name = Guid.NewGuid().ToString()
@@ -53,6 +53,6 @@ private static FieldsToSerialize CreateFieldsToSerialize(IResourceGraph resource
         }
 
         [Benchmark]
-        public object SerializeSimpleObject() => _jsonApiSerializer.Serialize(_content);
+        public object SerializeSimpleObject() => _jsonApiSerializer.Serialize(Content);
     }
 }

src/Examples/JsonApiDotNetCoreExample/Startups/Startup.cs

@@ -14,7 +14,7 @@ namespace JsonApiDotNetCoreExample.Startups
 {
     public class Startup : EmptyStartup
     {
-        private static readonly Version _postgresCiBuildVersion = new Version(9, 6);
+        private static readonly Version PostgresCiBuildVersion = new Version(9, 6);
         private readonly string _connectionString;
 
         public Startup(IConfiguration configuration)
@@ -31,7 +31,7 @@ public override void ConfigureServices(IServiceCollection services)
             services.AddDbContext<AppDbContext>(options =>
             {
                 options.EnableSensitiveDataLogging();
-                options.UseNpgsql(_connectionString, postgresOptions => postgresOptions.SetPostgresVersion(_postgresCiBuildVersion));
+                options.UseNpgsql(_connectionString, postgresOptions => postgresOptions.SetPostgresVersion(PostgresCiBuildVersion));
             });
 
             services.AddJsonApi<AppDbContext>(ConfigureJsonApiOptions, discovery => discovery.AddCurrentAssembly());

src/JsonApiDotNetCore/Configuration/ResourceGraph.cs

@@ -11,7 +11,7 @@ namespace JsonApiDotNetCore.Configuration
     public class ResourceGraph : IResourceGraph
     {
         private readonly IReadOnlyCollection<ResourceContext> _resources;
-        private static readonly Type _proxyTargetAccessorType = Type.GetType("Castle.DynamicProxy.IProxyTargetAccessor, Castle.Core");
+        private static readonly Type ProxyTargetAccessorType = Type.GetType("Castle.DynamicProxy.IProxyTargetAccessor, Castle.Core");
 
         public ResourceGraph(IReadOnlyCollection<ResourceContext> resources)
         {
@@ -171,7 +171,7 @@ private IReadOnlyCollection<ResourceFieldAttribute> Getter<TResource>(Expression
         }
 
         private bool IsLazyLoadingProxyForResourceType(Type resourceType) =>
-            _proxyTargetAccessorType?.IsAssignableFrom(resourceType) ?? false;
+            ProxyTargetAccessorType?.IsAssignableFrom(resourceType) ?? false;
 
         private static Expression RemoveConvert(Expression expression)
         {

src/JsonApiDotNetCore/Errors/JsonApiException.cs

@@ -11,7 +11,7 @@ namespace JsonApiDotNetCore.Errors
     /// </summary>
     public class JsonApiException : Exception
     {
-        private static readonly JsonSerializerSettings _errorSerializerSettings = new JsonSerializerSettings
+        private static readonly JsonSerializerSettings ErrorSerializerSettings = new JsonSerializerSettings
         {
             NullValueHandling = NullValueHandling.Ignore,
             Formatting = Formatting.Indented
@@ -40,6 +40,6 @@ public JsonApiException(IEnumerable<Error> errors, Exception innerException = nu
             }
         }
 
-        public override string Message => "Errors = " + JsonConvert.SerializeObject(Errors, _errorSerializerSettings);
+        public override string Message => "Errors = " + JsonConvert.SerializeObject(Errors, ErrorSerializerSettings);
     }
 }

src/JsonApiDotNetCore/Middleware/JsonApiMiddleware.cs

@@ -23,8 +23,8 @@ namespace JsonApiDotNetCore.Middleware
     /// </summary>
     public sealed class JsonApiMiddleware
     {
-        private static readonly MediaTypeHeaderValue _mediaType = MediaTypeHeaderValue.Parse(HeaderConstants.MediaType);
-        private static readonly MediaTypeHeaderValue _atomicOperationsMediaType = MediaTypeHeaderValue.Parse(HeaderConstants.AtomicOperationsMediaType);
+        private static readonly MediaTypeHeaderValue MediaType = MediaTypeHeaderValue.Parse(HeaderConstants.MediaType);
+        private static readonly MediaTypeHeaderValue AtomicOperationsMediaType = MediaTypeHeaderValue.Parse(HeaderConstants.AtomicOperationsMediaType);
 
         private readonly RequestDelegate _next;
 
@@ -51,7 +51,7 @@ public async Task Invoke(HttpContext httpContext,
             if (primaryResourceContext != null)
             {
                 if (!await ValidateContentTypeHeaderAsync(HeaderConstants.MediaType, httpContext, options.SerializerSettings) || 
-                    !await ValidateAcceptHeaderAsync(_mediaType, httpContext, options.SerializerSettings))
+                    !await ValidateAcceptHeaderAsync(MediaType, httpContext, options.SerializerSettings))
                 {
                     return;
                 }
@@ -63,7 +63,7 @@ public async Task Invoke(HttpContext httpContext,
             else if (IsOperationsRequest(routeValues))
             {
                 if (!await ValidateContentTypeHeaderAsync(HeaderConstants.AtomicOperationsMediaType, httpContext, options.SerializerSettings) || 
-                    !await ValidateAcceptHeaderAsync(_atomicOperationsMediaType, httpContext, options.SerializerSettings))
+                    !await ValidateAcceptHeaderAsync(AtomicOperationsMediaType, httpContext, options.SerializerSettings))
                 {
                     return;
                 }

src/JsonApiDotNetCore/Queries/Internal/QueryableBuilding/SelectClauseBuilder.cs

@@ -18,7 +18,7 @@ namespace JsonApiDotNetCore.Queries.Internal.QueryableBuilding
     /// </summary>
     public class SelectClauseBuilder : QueryClauseBuilder<object>
     {
-        private static readonly ConstantExpression _nullConstant = Expression.Constant(null);
+        private static readonly ConstantExpression NullConstant = Expression.Constant(null);
 
         private readonly Expression _source;
         private readonly IModel _entityModel;
@@ -207,8 +207,8 @@ private Expression CreateCollectionInitializer(LambdaScope lambdaScope, Property
 
         private static Expression TestForNull(Expression expressionToTest, Expression ifFalseExpression)
         {
-            BinaryExpression equalsNull = Expression.Equal(expressionToTest, _nullConstant);
-            return Expression.Condition(equalsNull, Expression.Convert(_nullConstant, expressionToTest.Type), ifFalseExpression);
+            BinaryExpression equalsNull = Expression.Equal(expressionToTest, NullConstant);
+            return Expression.Condition(equalsNull, Expression.Convert(NullConstant, expressionToTest.Type), ifFalseExpression);
         }
 
         private static Expression CopyCollectionExtensionMethodCall(Expression source, string operationName, Type elementType)

src/JsonApiDotNetCore/Queries/Internal/QueryableBuilding/WhereClauseBuilder.cs

@@ -14,7 +14,7 @@ namespace JsonApiDotNetCore.Queries.Internal.QueryableBuilding
     /// </summary>
     public class WhereClauseBuilder : QueryClauseBuilder<Type>
     {
-        private static readonly ConstantExpression _nullConstant = Expression.Constant(null);
+        private static readonly ConstantExpression NullConstant = Expression.Constant(null);
 
         private readonly Expression _source;
         private readonly Type _extensionType;
@@ -252,7 +252,7 @@ private static Expression WrapInConvert(Expression expression, Type targetType)
 
         public override Expression VisitNullConstant(NullConstantExpression expression, Type expressionType)
         {
-            return _nullConstant;
+            return NullConstant;
         }
 
         public override Expression VisitLiteralConstant(LiteralConstantExpression expression, Type expressionType)

src/JsonApiDotNetCore/QueryStrings/Internal/FilterQueryStringParameterReader.cs

@@ -16,7 +16,7 @@ namespace JsonApiDotNetCore.QueryStrings.Internal
 {
     public class FilterQueryStringParameterReader : QueryStringParameterReader, IFilterQueryStringParameterReader
     {
-        private static readonly LegacyFilterNotationConverter _legacyConverter = new LegacyFilterNotationConverter();
+        private static readonly LegacyFilterNotationConverter LegacyConverter = new LegacyFilterNotationConverter();
 
         private readonly IJsonApiOptions _options;
         private readonly QueryStringParameterScopeParser _scopeParser;
@@ -79,7 +79,7 @@ private IEnumerable<string> ExtractParameterValues(string parameterName, StringV
             {
                 if (_options.EnableLegacyFilterNotation)
                 {
-                    foreach (string condition in _legacyConverter.ExtractConditions(parameterName, parameterValue))
+                    foreach (string condition in LegacyConverter.ExtractConditions(parameterName, parameterValue))
                     {
                         yield return condition;
                     }
@@ -97,7 +97,7 @@ private void ReadSingleValue(string parameterName, string parameterValue)
             {
                 if (_options.EnableLegacyFilterNotation)
                 {
-                    (parameterName, parameterValue) = _legacyConverter.Convert(parameterName, parameterValue);
+                    (parameterName, parameterValue) = LegacyConverter.Convert(parameterName, parameterValue);
                 }
 
                 ResourceFieldChainExpression scope = GetScope(parameterName);

src/JsonApiDotNetCore/QueryStrings/Internal/LegacyFilterNotationConverter.cs

@@ -15,7 +15,7 @@ public sealed class LegacyFilterNotationConverter
         private const string InPrefix = "in:";
         private const string NotInPrefix = "nin:";
 
-        private static readonly Dictionary<string, string> _prefixConversionTable = new Dictionary<string, string>
+        private static readonly Dictionary<string, string> PrefixConversionTable = new Dictionary<string, string>
         {
             ["eq:"] = Keywords.Equals,
             ["lt:"] = Keywords.LessThan,
@@ -55,7 +55,7 @@ public IEnumerable<string> ExtractConditions(string parameterName, string parame
 
             var attributeName = ExtractAttributeName(parameterName);
 
-            foreach (var (prefix, keyword) in _prefixConversionTable)
+            foreach (var (prefix, keyword) in PrefixConversionTable)
             {
                 if (parameterValue.StartsWith(prefix, StringComparison.Ordinal))
                 {