Skip to content

Commit 4a44dc4

Browse files
author
Bart Koelman
committed
Removed non-generic Identifiable and throw for resource classes that only implement IIdentifiable (without ID) when building the resource graph
1 parent 29e5c84 commit 4a44dc4

File tree

121 files changed

+181
-179
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

121 files changed

+181
-179
lines changed

benchmarks/BenchmarkResource.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
namespace Benchmarks
66
{
77
[UsedImplicitly(ImplicitUseTargetFlags.Members)]
8-
public sealed class BenchmarkResource : Identifiable
8+
public sealed class BenchmarkResource : Identifiable<int>
99
{
1010
[Attr(PublicName = BenchmarkResourcePublicNames.NameAttr)]
1111
public string Name { get; set; }

benchmarks/Deserialization/DeserializationBenchmarkBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ protected DeserializationBenchmarkBase()
5656
protected abstract JsonApiRequest CreateJsonApiRequest(IResourceGraph resourceGraph);
5757

5858
[UsedImplicitly(ImplicitUseTargetFlags.Members)]
59-
public sealed class ResourceA : Identifiable
59+
public sealed class ResourceA : Identifiable<int>
6060
{
6161
[Attr]
6262
public bool Attribute01 { get; set; }

benchmarks/Serialization/SerializationBenchmarkBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ protected SerializationBenchmarkBase()
6464
protected abstract IEvaluatedIncludeCache CreateEvaluatedIncludeCache(IResourceGraph resourceGraph);
6565

6666
[UsedImplicitly(ImplicitUseTargetFlags.Members)]
67-
public sealed class ResourceA : Identifiable
67+
public sealed class ResourceA : Identifiable<int>
6868
{
6969
[Attr]
7070
public bool Attribute01 { get; set; }

benchmarks/SubResource.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
namespace Benchmarks
66
{
77
[UsedImplicitly(ImplicitUseTargetFlags.Members)]
8-
public sealed class SubResource : Identifiable
8+
public sealed class SubResource : Identifiable<int>
99
{
1010
[Attr]
1111
public string Value { get; set; }

src/Examples/GettingStarted/Models/Book.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
namespace GettingStarted.Models
66
{
77
[UsedImplicitly(ImplicitUseTargetFlags.Members)]
8-
public sealed class Book : Identifiable
8+
public sealed class Book : Identifiable<int>
99
{
1010
[Attr]
1111
public string Title { get; set; }

src/Examples/GettingStarted/Models/Person.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
namespace GettingStarted.Models
77
{
88
[UsedImplicitly(ImplicitUseTargetFlags.Members)]
9-
public sealed class Person : Identifiable
9+
public sealed class Person : Identifiable<int>
1010
{
1111
[Attr]
1212
public string Name { get; set; }

src/Examples/JsonApiDotNetCoreExample/Models/Person.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
namespace JsonApiDotNetCoreExample.Models
77
{
88
[UsedImplicitly(ImplicitUseTargetFlags.Members)]
9-
public sealed class Person : Identifiable
9+
public sealed class Person : Identifiable<int>
1010
{
1111
[Attr]
1212
public string FirstName { get; set; }

src/Examples/JsonApiDotNetCoreExample/Models/Tag.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
namespace JsonApiDotNetCoreExample.Models
88
{
99
[UsedImplicitly(ImplicitUseTargetFlags.Members)]
10-
public sealed class Tag : Identifiable
10+
public sealed class Tag : Identifiable<int>
1111
{
1212
[Required]
1313
[MinLength(1)]

src/Examples/JsonApiDotNetCoreExample/Models/TodoItem.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
namespace JsonApiDotNetCoreExample.Models
88
{
99
[UsedImplicitly(ImplicitUseTargetFlags.Members)]
10-
public sealed class TodoItem : Identifiable
10+
public sealed class TodoItem : Identifiable<int>
1111
{
1212
[Attr]
1313
public string Description { get; set; }

src/Examples/MultiDbContextExample/Models/ResourceA.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
namespace MultiDbContextExample.Models
66
{
77
[UsedImplicitly(ImplicitUseTargetFlags.Members)]
8-
public sealed class ResourceA : Identifiable
8+
public sealed class ResourceA : Identifiable<int>
99
{
1010
[Attr]
1111
public string NameA { get; set; }

0 commit comments

Comments
 (0)