Skip to content

Commit 748ce06

Browse files
authored
Merge pull request #111 from Research-Institute/develop
v2.0.6
2 parents 2f3b618 + f765d74 commit 748ce06

File tree

4 files changed

+8
-11
lines changed

4 files changed

+8
-11
lines changed

docs/Errors.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ public override async Task<IActionResult> PostAsync([FromBody] MyEntity entity)
3131
return Error(new CustomError("507", "Database is full.", "Theres no more room.", "Sorry."));
3232

3333
if(model.Validations.IsValid == false)
34-
return Errors(model.Validations.Select(v => v.GetErrors()));
35-
34+
return Errors(model.Validations.GetErrors());
35+
3636
// ...
3737
}
3838
```

src/JsonApiDotNetCore/Controllers/JsonApiController.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,11 @@ public virtual async Task<IActionResult> GetAsync(TId id)
6464
[HttpGet("{id}/relationships/{relationshipName}")]
6565
public virtual async Task<IActionResult> GetRelationshipsAsync(TId id, string relationshipName)
6666
{
67-
var relationship = _resourceService.GetRelationshipsAsync(id, relationshipName);
67+
var relationship = await _resourceService.GetRelationshipsAsync(id, relationshipName);
6868
if(relationship == null)
6969
return NotFound();
7070

71-
return await GetRelationshipAsync(id, relationshipName);
71+
return Ok(relationship);
7272
}
7373

7474
[HttpGet("{id}/{relationshipName}")]

src/JsonApiDotNetCore/Data/DefaultEntityRepository.cs

+3-6
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public virtual IQueryable<TEntity> Get()
5151
{
5252
if(_jsonApiContext.QuerySet?.Fields != null && _jsonApiContext.QuerySet.Fields.Any())
5353
return _dbSet.Select(_jsonApiContext.QuerySet?.Fields);
54-
54+
5555
return _dbSet;
5656
}
5757

@@ -92,12 +92,9 @@ public virtual async Task<TEntity> GetAndIncludeAsync(TId id, string relationshi
9292

9393
var result = await Get()
9494
.Include(relationshipName)
95-
.Where(e => e.Id.Equals(id))
96-
.ToListAsync();
97-
98-
_logger.LogDebug($"[JADN] Found {result.Count} entity");
95+
.SingleOrDefaultAsync(e => e.Id.Equals(id));
9996

100-
return result.SingleOrDefault();
97+
return result;
10198
}
10299

103100
public virtual async Task<TEntity> CreateAsync(TEntity entity)

src/JsonApiDotNetCore/JsonApiDotNetCore.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
3-
<VersionPrefix>2.0.5</VersionPrefix>
3+
<VersionPrefix>2.0.6</VersionPrefix>
44
<TargetFrameworks>netstandard1.6</TargetFrameworks>
55
<AssemblyName>JsonApiDotNetCore</AssemblyName>
66
<PackageId>JsonApiDotNetCore</PackageId>

0 commit comments

Comments
 (0)