Use char overload instead of passing a single-char string

Author: bkoelman

src/JsonApiDotNetCore.Annotations/TypeExtensions.cs

@@ -48,7 +48,7 @@ public static string GetFriendlyTypeName(this Type type)
         if (type.IsGenericType)
         {
             string typeArguments = type.GetGenericArguments().Select(GetFriendlyTypeName).Aggregate((firstType, secondType) => $"{firstType}, {secondType}");
-            return $"{type.Name[..type.Name.IndexOf("`", StringComparison.Ordinal)]}<{typeArguments}>";
+            return $"{type.Name[..type.Name.IndexOf('`')]}<{typeArguments}>";
         }
 
         return type.Name;

src/JsonApiDotNetCore/QueryStrings/FilterQueryStringParameterReader.cs

@@ -52,7 +52,7 @@ public virtual bool CanRead(string parameterName)
     {
         ArgumentGuard.NotNullNorEmpty(parameterName);
 
-        bool isNested = parameterName.StartsWith("filter[", StringComparison.Ordinal) && parameterName.EndsWith("]", StringComparison.Ordinal);
+        bool isNested = parameterName.StartsWith("filter[", StringComparison.Ordinal) && parameterName.EndsWith(']');
         return parameterName == "filter" || isNested;
     }
 

src/JsonApiDotNetCore/QueryStrings/SortQueryStringParameterReader.cs

@@ -45,7 +45,7 @@ public virtual bool CanRead(string parameterName)
     {
         ArgumentGuard.NotNullNorEmpty(parameterName);
 
-        bool isNested = parameterName.StartsWith("sort[", StringComparison.Ordinal) && parameterName.EndsWith("]", StringComparison.Ordinal);
+        bool isNested = parameterName.StartsWith("sort[", StringComparison.Ordinal) && parameterName.EndsWith(']');
         return parameterName == "sort" || isNested;
     }
 

src/JsonApiDotNetCore/QueryStrings/SparseFieldSetQueryStringParameterReader.cs

@@ -50,7 +50,7 @@ public virtual bool CanRead(string parameterName)
     {
         ArgumentGuard.NotNullNorEmpty(parameterName);
 
-        return parameterName.StartsWith("fields[", StringComparison.Ordinal) && parameterName.EndsWith("]", StringComparison.Ordinal);
+        return parameterName.StartsWith("fields[", StringComparison.Ordinal) && parameterName.EndsWith(']');
     }
 
     /// <inheritdoc />

test/JsonApiDotNetCoreTests/IntegrationTests/IdObfuscation/HexadecimalCodec.cs

@@ -15,7 +15,7 @@ public int Decode(string? value)
             return 0;
         }
 
-        if (!value.StartsWith("x", StringComparison.Ordinal))
+        if (!value.StartsWith('x'))
         {
             throw new JsonApiException(new ErrorObject(HttpStatusCode.BadRequest)
             {