Fail at startup on controller that derives from BaseJsonApiController, but uses a resource type that is not registered in the resource graph

Author: Bart Koelman

src/JsonApiDotNetCore/Middleware/JsonApiRoutingConvention.cs

@@ -84,6 +84,11 @@ public void Apply(ApplicationModel application)
                             _resourceTypePerControllerTypeMap.Add(controller.ControllerType, resourceType);
                             _controllerPerResourceTypeMap.Add(resourceType, controller);
                         }
+                        else
+                        {
+                            throw new InvalidConfigurationException($"Controller '{controller.ControllerType}' depends on " +
+                                $"resource type '{resourceClrType}', which does not exist in the resource graph.");
+                        }
                     }
                 }
 

test/JsonApiDotNetCoreTests/IntegrationTests/NonJsonApiControllers/UnknownResource.cs

@@ -0,0 +1,11 @@
+using JetBrains.Annotations;
+using JsonApiDotNetCore.Resources;
+
+namespace JsonApiDotNetCoreTests.IntegrationTests.NonJsonApiControllers
+{
+    [UsedImplicitly(ImplicitUseTargetFlags.Members)]
+    public sealed class UnknownResource : Identifiable<int>
+    {
+        public string? Value { get; set; }
+    }
+}

test/JsonApiDotNetCoreTests/IntegrationTests/NonJsonApiControllers/UnknownResourceControllerTests.cs

@@ -0,0 +1,32 @@
+using System;
+using FluentAssertions;
+using JsonApiDotNetCore.Errors;
+using TestBuildingBlocks;
+using Xunit;
+
+namespace JsonApiDotNetCoreTests.IntegrationTests.NonJsonApiControllers
+{
+    public sealed class UnknownResourceControllerTests : IntegrationTestContext<TestableStartup<NonJsonApiDbContext>, NonJsonApiDbContext>
+    {
+        public UnknownResourceControllerTests()
+        {
+            UseController<UnknownResourcesController>();
+        }
+
+        [Fact]
+        public void Fails_at_startup_when_using_controller_for_resource_type_that_is_not_registered_in_resource_graph()
+        {
+            // Act
+            Action action = () => _ = Factory;
+
+            // Assert
+            action.Should().ThrowExactly<InvalidConfigurationException>().WithMessage($"Controller '{typeof(UnknownResourcesController)}' " +
+                $"depends on resource type '{typeof(UnknownResource)}', which does not exist in the resource graph.");
+        }
+
+        public override void Dispose()
+        {
+            // Prevents crash when test cleanup tries to access lazily constructed Factory.
+        }
+    }
+}

test/JsonApiDotNetCoreTests/IntegrationTests/NonJsonApiControllers/UnknownResourcesController.cs

@@ -0,0 +1,16 @@
+using JsonApiDotNetCore.Configuration;
+using JsonApiDotNetCore.Controllers;
+using JsonApiDotNetCore.Services;
+using Microsoft.Extensions.Logging;
+
+namespace JsonApiDotNetCoreTests.IntegrationTests.NonJsonApiControllers
+{
+    public sealed class UnknownResourcesController : JsonApiController<UnknownResource, int>
+    {
+        public UnknownResourcesController(IJsonApiOptions options, IResourceGraph resourceGraph, ILoggerFactory loggerFactory,
+            IResourceService<UnknownResource, int> resourceService)
+            : base(options, resourceGraph, loggerFactory, resourceService)
+        {
+        }
+    }
+}

test/TestBuildingBlocks/IntegrationTestContext.cs

@@ -111,7 +111,7 @@ private WebApplicationFactory<TStartup> CreateFactory()
             return factoryWithConfiguredContentRoot;
         }
 
-        public void Dispose()
+        public virtual void Dispose()
         {
             RunOnDatabaseAsync(async dbContext => await dbContext.Database.EnsureDeletedAsync()).Wait();