Remove ArrayFactory.Create

Author: bkoelman

benchmarks/QueryString/QueryStringParserBenchmarks.cs

@@ -1,7 +1,6 @@
 using System.ComponentModel.Design;
 using BenchmarkDotNet.Attributes;
 using Benchmarks.Tools;
-using JsonApiDotNetCore;
 using JsonApiDotNetCore.Configuration;
 using JsonApiDotNetCore.Middleware;
 using JsonApiDotNetCore.Queries.Parsing;
@@ -55,8 +54,14 @@ public QueryStringParserBenchmarks()
         var paginationParser = new PaginationParser();
         var paginationReader = new PaginationQueryStringParameterReader(paginationParser, request, resourceGraph, options);
 
-        IQueryStringParameterReader[] readers = ArrayFactory.Create<IQueryStringParameterReader>(includeReader, filterReader, sortReader,
-            sparseFieldSetReader, paginationReader);
+        IQueryStringParameterReader[] readers =
+        [
+            includeReader,
+            filterReader,
+            sortReader,
+            sparseFieldSetReader,
+            paginationReader
+        ];
 
         _queryStringReader = new QueryStringReader(options, _queryStringAccessor, readers, NullLoggerFactory.Instance);
     }

src/JsonApiDotNetCore/ArrayFactory.cs

@@ -152,9 +152,11 @@ private void AddResourceDefinitions(Assembly assembly, ResourceDescriptor resour
 
     private void RegisterImplementations(Assembly assembly, Type interfaceType, ResourceDescriptor resourceDescriptor)
     {
-        Type[] typeArguments = interfaceType.GetTypeInfo().GenericTypeParameters.Length == 2
-            ? ArrayFactory.Create(resourceDescriptor.ResourceClrType, resourceDescriptor.IdClrType)
-            : ArrayFactory.Create(resourceDescriptor.ResourceClrType);
+        Type[] typeArguments =
+        [
+            resourceDescriptor.ResourceClrType,
+            resourceDescriptor.IdClrType
+        ];
 
         (Type implementationType, Type serviceInterface)? result = _typeLocator.GetContainerRegistrationFromAssembly(assembly, interfaceType, typeArguments);
 

src/JsonApiDotNetCore/Configuration/ServiceDiscoveryFacade.cs

@@ -207,7 +207,12 @@ private abstract class ModelStateKeySegment
         private const char Dot = '.';
         private const char BracketOpen = '[';
         private const char BracketClose = ']';
-        private static readonly char[] KeySegmentStartTokens = ArrayFactory.Create(Dot, BracketOpen);
+
+        private static readonly char[] KeySegmentStartTokens =
+        [
+            Dot,
+            BracketOpen
+        ];
 
         // The right part of the full key, which nested segments are produced from.
         private readonly string _nextKey;

src/JsonApiDotNetCore/Errors/InvalidModelStateException.cs

@@ -57,7 +57,12 @@ private static string GetOperationName(bool isAscending, QueryClauseBuilderConte
     private static Expression ExtensionMethodCall(Expression source, string operationName, Type keyType, LambdaExpression keySelector,
         QueryClauseBuilderContext context)
     {
-        Type[] typeArguments = ArrayFactory.Create(context.LambdaScope.Parameter.Type, keyType);
+        Type[] typeArguments =
+        [
+            context.LambdaScope.Parameter.Type,
+            keyType
+        ];
+
         return Expression.Call(context.ExtensionType, operationName, typeArguments, source, keySelector);
     }
 }

src/JsonApiDotNetCore/Queries/QueryableBuilding/OrderClauseBuilder.cs

@@ -247,7 +247,12 @@ private static Expression CopyCollectionExtensionMethodCall(Expression source, s
 
     private static Expression SelectExtensionMethodCall(Type extensionType, Expression source, Type elementType, Expression selectBody)
     {
-        Type[] typeArguments = ArrayFactory.Create(elementType, elementType);
+        Type[] typeArguments =
+        [
+            elementType,
+            elementType
+        ];
+
         return Expression.Call(extensionType, "Select", typeArguments, source, selectBody);
     }
 

src/JsonApiDotNetCore/Queries/QueryableBuilding/SelectClauseBuilder.cs

@@ -50,7 +50,7 @@ private static IIdentifiable CreateWrapperForAbstractType(Type resourceClrType)
         Type wrapperClrType = typeof(AbstractResourceWrapper<>).MakeGenericType(descriptor.IdClrType);
         ConstructorInfo constructor = wrapperClrType.GetConstructors().Single();
 
-        object resource = constructor.Invoke(ArrayFactory.Create<object>(resourceClrType));
+        object resource = constructor.Invoke([resourceClrType]);
         return (IIdentifiable)resource;
     }
 

src/JsonApiDotNetCore/Resources/ResourceFactory.cs

@@ -17,7 +17,13 @@ public ETagGenerator(IFingerprintGenerator fingerprintGenerator)
     /// <inheritdoc />
     public EntityTagHeaderValue Generate(string requestUrl, string responseBody)
     {
-        string fingerprint = _fingerprintGenerator.Generate(ArrayFactory.Create(requestUrl, responseBody));
+        string[] elements =
+        [
+            requestUrl,
+            responseBody
+        ];
+
+        string fingerprint = _fingerprintGenerator.Generate(elements);
         string eTagValue = $"\"{fingerprint}\"";
 
         return EntityTagHeaderValue.Parse(eTagValue);

src/JsonApiDotNetCore/Serialization/Response/ETagGenerator.cs

@@ -1,6 +1,5 @@
 using System.Net;
 using FluentAssertions;
-using JsonApiDotNetCore;
 using JsonApiDotNetCore.Serialization.Objects;
 using Microsoft.EntityFrameworkCore;
 using TestBuildingBlocks;
@@ -880,7 +879,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
             dbContext.WorkItems.Add(existingWorkItem);
             await dbContext.SaveChangesAsync();
 
-            existingWorkItem.RelatedFrom = ArrayFactory.Create(existingWorkItem);
+            existingWorkItem.RelatedFrom = [existingWorkItem];
             await dbContext.SaveChangesAsync();
         });
 

test/JsonApiDotNetCoreTests/IntegrationTests/ReadWrite/Updating/Relationships/ReplaceToManyRelationshipTests.cs

@@ -965,7 +965,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
             dbContext.WorkItems.Add(existingWorkItem);
             await dbContext.SaveChangesAsync();
 
-            existingWorkItem.RelatedFrom = ArrayFactory.Create(existingWorkItem);
+            existingWorkItem.RelatedFrom = [existingWorkItem];
             await dbContext.SaveChangesAsync();
         });
 

test/JsonApiDotNetCoreTests/IntegrationTests/ReadWrite/Updating/Resources/ReplaceToManyRelationshipTests.cs

@@ -82,7 +82,7 @@ public override Task OnWriteSucceededAsync(TResource resource, WriteOperationKin
 
     private void EnsureSnapshot(TResource leftType, IIdentifiable? rightResourceId = null)
     {
-        IIdentifiable[] rightResourceIds = rightResourceId != null ? ArrayFactory.Create(rightResourceId) : Array.Empty<IIdentifiable>();
+        IIdentifiable[] rightResourceIds = rightResourceId != null ? [rightResourceId] : Array.Empty<IIdentifiable>();
 
         EnsureSnapshot(leftType, rightResourceIds);
     }