Skip to content

Commit bd98085

Browse files
committed
fix(JsonApiDeSerializer): throw on possible null exception
1 parent 76d4f7c commit bd98085

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

src/JsonApiDotNetCore/Serialization/JsonApiDeSerializer.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,9 +169,12 @@ private object SetHasOneRelationship(object entity,
169169
if (relationships.TryGetValue(relationshipName, out RelationshipData relationshipData))
170170
{
171171
var relationshipAttr = _jsonApiContext.RequestEntity.Relationships
172-
.SingleOrDefault(r => r.PublicRelationshipName == relationshipName);
172+
.SingleOrDefault(r => r.PublicRelationshipName == relationshipName);
173173

174-
var data = (Dictionary<string, string>)relationshipData.ExposedData;
174+
if (relationshipAttr == null)
175+
throw new JsonApiException(400, $"{_jsonApiContext.RequestEntity.EntityName} does not contain a relationship '{relationshipName}'");
176+
177+
var data = (Dictionary<string, string>) relationshipData.ExposedData;
175178

176179
if (data == null) return entity;
177180

0 commit comments

Comments
 (0)