Tryout: update to latest JetBrains tools to diagnose cibuild

Bart Koelman · Bart Koelman · commit d592bd25e79c · 2021-11-01T17:01:23.000+01:00
diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
@@ -3,7 +3,7 @@
   "isRoot": true,
   "tools": {
     "jetbrains.resharper.globaltools": {
-      "version": "2021.1.4",
+      "version": "2021.2.2",
       "commands": [
         "jb"
       ]
diff --git a/Build.ps1 b/Build.ps1
@@ -100,7 +100,7 @@ dotnet build -c Release
 CheckLastExitCode
 
 RunInspectCode
-#RunCleanupCode
+RunCleanupCode
 
 dotnet test -c Release --no-build --collect:"XPlat Code Coverage"
 CheckLastExitCode
diff --git a/benchmarks/Deserialization/OperationsDeserializationBenchmarks.cs b/benchmarks/Deserialization/OperationsDeserializationBenchmarks.cs
@@ -276,7 +276,7 @@ public class OperationsDeserializationBenchmarks : DeserializationBenchmarkBase
 
         protected override JsonApiRequest CreateJsonApiRequest(IResourceGraph resourceGraph)
         {
-            return new()
+            return new JsonApiRequest
             {
                 Kind = EndpointKind.AtomicOperations
             };
diff --git a/benchmarks/Deserialization/ResourceDeserializationBenchmarks.cs b/benchmarks/Deserialization/ResourceDeserializationBenchmarks.cs
@@ -139,7 +139,7 @@ public class ResourceDeserializationBenchmarks : DeserializationBenchmarkBase
 
         protected override JsonApiRequest CreateJsonApiRequest(IResourceGraph resourceGraph)
         {
-            return new()
+            return new JsonApiRequest
             {
                 Kind = EndpointKind.Primary,
                 PrimaryResourceType = resourceGraph.GetResourceType<IncomingResource>(),
diff --git a/benchmarks/Serialization/OperationsSerializationBenchmarks.cs b/benchmarks/Serialization/OperationsSerializationBenchmarks.cs
@@ -122,7 +122,7 @@ public string SerializeOperationsResponse()
 
         protected override JsonApiRequest CreateJsonApiRequest(IResourceGraph resourceGraph)
         {
-            return new()
+            return new JsonApiRequest
             {
                 Kind = EndpointKind.AtomicOperations,
                 PrimaryResourceType = resourceGraph.GetResourceType<OutgoingResource>()
diff --git a/benchmarks/Serialization/ResourceSerializationBenchmarks.cs b/benchmarks/Serialization/ResourceSerializationBenchmarks.cs
@@ -113,7 +113,7 @@ public string SerializeResourceResponse()
 
         protected override JsonApiRequest CreateJsonApiRequest(IResourceGraph resourceGraph)
         {
-            return new()
+            return new JsonApiRequest
             {
                 Kind = EndpointKind.Primary,
                 PrimaryResourceType = resourceGraph.GetResourceType<OutgoingResource>()
diff --git a/benchmarks/Serialization/SerializationBenchmarkBase.cs b/benchmarks/Serialization/SerializationBenchmarkBase.cs
@@ -223,23 +223,23 @@ private sealed class FakeLinkBuilder : ILinkBuilder
         {
             public TopLevelLinks GetTopLevelLinks()
             {
-                return new()
+                return new TopLevelLinks
                 {
                     Self = "TopLevel:Self"
                 };
             }
 
             public ResourceLinks GetResourceLinks(ResourceType resourceType, string id)
             {
-                return new()
+                return new ResourceLinks
                 {
                     Self = "Resource:Self"
                 };
             }
 
             public RelationshipLinks GetRelationshipLinks(RelationshipAttribute relationship, string leftId)
             {
-                return new()
+                return new RelationshipLinks
                 {
                     Self = "Relationship:Self",
                     Related = "Relationship:Related"
diff --git a/src/JsonApiDotNetCore/Errors/ResourcesInRelationshipsNotFoundException.cs b/src/JsonApiDotNetCore/Errors/ResourcesInRelationshipsNotFoundException.cs
@@ -19,7 +19,7 @@ public ResourcesInRelationshipsNotFoundException(IEnumerable<MissingResourceInRe
 
         private static ErrorObject CreateError(MissingResourceInRelationship missingResourceInRelationship)
         {
-            return new(HttpStatusCode.NotFound)
+            return new ErrorObject(HttpStatusCode.NotFound)
             {
                 Title = "A related resource does not exist.",
                 Detail = $"Related resource of type '{missingResourceInRelationship.ResourceType}' with ID '{missingResourceInRelationship.ResourceId}' " +
diff --git a/src/JsonApiDotNetCore/ObjectExtensions.cs b/src/JsonApiDotNetCore/ObjectExtensions.cs
@@ -21,15 +21,15 @@ public static T[] AsArray<T>(this T element)
 
         public static List<T> AsList<T>(this T element)
         {
-            return new()
+            return new List<T>
             {
                 element
             };
         }
 
         public static HashSet<T> AsHashSet<T>(this T element)
         {
-            return new()
+            return new HashSet<T>
             {
                 element
             };
diff --git a/src/JsonApiDotNetCore/Serialization/JsonConverters/JsonObjectConverter.cs b/src/JsonApiDotNetCore/Serialization/JsonConverters/JsonObjectConverter.cs
@@ -29,7 +29,7 @@ protected static void WriteSubTree<TValue>(Utf8JsonWriter writer, TValue value,
 
         protected static JsonException GetEndOfStreamError()
         {
-            return new("Unexpected end of JSON stream.");
+            return new JsonException("Unexpected end of JSON stream.");
         }
     }
 }
diff --git a/src/JsonApiDotNetCore/Serialization/Response/ResourceObjectTreeNode.cs b/src/JsonApiDotNetCore/Serialization/Response/ResourceObjectTreeNode.cs
@@ -51,7 +51,7 @@ public ResourceObjectTreeNode(IIdentifiable resource, ResourceType type, Resourc
 
         public static ResourceObjectTreeNode CreateRoot()
         {
-            return new(RootResource, RootType, new ResourceObject());
+            return new ResourceObjectTreeNode(RootResource, RootType, new ResourceObject());
         }
 
         public void AttachDirectChild(ResourceObjectTreeNode treeNode)
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/QueryStrings/MusicTrackReleaseDefinition.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/QueryStrings/MusicTrackReleaseDefinition.cs
@@ -24,7 +24,7 @@ public MusicTrackReleaseDefinition(IResourceGraph resourceGraph, ISystemClock sy
 
         public override QueryStringParameterHandlers<MusicTrack> OnRegisterQueryableHandlersForQueryStringParameters()
         {
-            return new()
+            return new QueryStringParameterHandlers<MusicTrack>
             {
                 ["isRecentlyReleased"] = FilterOnRecentlyReleased
             };
diff --git a/test/TestBuildingBlocks/HttpResponseMessageExtensions.cs b/test/TestBuildingBlocks/HttpResponseMessageExtensions.cs
@@ -11,7 +11,7 @@ public static class HttpResponseMessageExtensions
     {
         public static HttpResponseMessageAssertions Should(this HttpResponseMessage instance)
         {
-            return new(instance);
+            return new HttpResponseMessageAssertions(instance);
         }
 
         public sealed class HttpResponseMessageAssertions : ReferenceTypeAssertions<HttpResponseMessage, HttpResponseMessageAssertions>

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`"isRoot": true,`
`4`	`4`	`"tools": {`
`5`	`5`	`"jetbrains.resharper.globaltools": {`
`6`		`- "version": "2021.1.4",`
	`6`	`+ "version": "2021.2.2",`
`7`	`7`	`"commands": [`
`8`	`8`	`"jb"`
`9`	`9`	`]`
Original file line number	Diff line number	Diff line change
`@@ -276,7 +276,7 @@ public class OperationsDeserializationBenchmarks : DeserializationBenchmarkBase`
`276`	`276`
`277`	`277`	`protected override JsonApiRequest CreateJsonApiRequest(IResourceGraph resourceGraph)`
`278`	`278`	`{`
`279`		`- return new()`
	`279`	`+ return new JsonApiRequest`
`280`	`280`	`{`
`281`	`281`	`Kind = EndpointKind.AtomicOperations`
`282`	`282`	`};`
Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ public class ResourceDeserializationBenchmarks : DeserializationBenchmarkBase`
`139`	`139`
`140`	`140`	`protected override JsonApiRequest CreateJsonApiRequest(IResourceGraph resourceGraph)`
`141`	`141`	`{`
`142`		`- return new()`
	`142`	`+ return new JsonApiRequest`
`143`	`143`	`{`
`144`	`144`	`Kind = EndpointKind.Primary,`
`145`	`145`	`PrimaryResourceType = resourceGraph.GetResourceType<IncomingResource>(),`
Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ public string SerializeOperationsResponse()`
`122`	`122`
`123`	`123`	`protected override JsonApiRequest CreateJsonApiRequest(IResourceGraph resourceGraph)`
`124`	`124`	`{`
`125`		`- return new()`
	`125`	`+ return new JsonApiRequest`
`126`	`126`	`{`
`127`	`127`	`Kind = EndpointKind.AtomicOperations,`
`128`	`128`	`PrimaryResourceType = resourceGraph.GetResourceType<OutgoingResource>()`
Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ public string SerializeResourceResponse()`
`113`	`113`
`114`	`114`	`protected override JsonApiRequest CreateJsonApiRequest(IResourceGraph resourceGraph)`
`115`	`115`	`{`
`116`		`- return new()`
	`116`	`+ return new JsonApiRequest`
`117`	`117`	`{`
`118`	`118`	`Kind = EndpointKind.Primary,`
`119`	`119`	`PrimaryResourceType = resourceGraph.GetResourceType<OutgoingResource>()`
Original file line number	Diff line number	Diff line change
`@@ -223,23 +223,23 @@ private sealed class FakeLinkBuilder : ILinkBuilder`
`223`	`223`	`{`
`224`	`224`	`public TopLevelLinks GetTopLevelLinks()`
`225`	`225`	`{`
`226`		`- return new()`
	`226`	`+ return new TopLevelLinks`
`227`	`227`	`{`
`228`	`228`	`Self = "TopLevel:Self"`
`229`	`229`	`};`
`230`	`230`	`}`
`231`	`231`
`232`	`232`	`public ResourceLinks GetResourceLinks(ResourceType resourceType, string id)`
`233`	`233`	`{`
`234`		`- return new()`
	`234`	`+ return new ResourceLinks`
`235`	`235`	`{`
`236`	`236`	`Self = "Resource:Self"`
`237`	`237`	`};`
`238`	`238`	`}`
`239`	`239`
`240`	`240`	`public RelationshipLinks GetRelationshipLinks(RelationshipAttribute relationship, string leftId)`
`241`	`241`	`{`
`242`		`- return new()`
	`242`	`+ return new RelationshipLinks`
`243`	`243`	`{`
`244`	`244`	`Self = "Relationship:Self",`
`245`	`245`	`Related = "Relationship:Related"`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ public ResourcesInRelationshipsNotFoundException(IEnumerable<MissingResourceInRe`
`19`	`19`
`20`	`20`	`private static ErrorObject CreateError(MissingResourceInRelationship missingResourceInRelationship)`
`21`	`21`	`{`
`22`		`- return new(HttpStatusCode.NotFound)`
	`22`	`+ return new ErrorObject(HttpStatusCode.NotFound)`
`23`	`23`	`{`
`24`	`24`	`Title = "A related resource does not exist.",`
`25`	`25`	`Detail = $"Related resource of type '{missingResourceInRelationship.ResourceType}' with ID '{missingResourceInRelationship.ResourceId}' " +`
Original file line number	Diff line number	Diff line change
`@@ -21,15 +21,15 @@ public static T[] AsArray<T>(this T element)`
`21`	`21`
`22`	`22`	`public static List<T> AsList<T>(this T element)`
`23`	`23`	`{`
`24`		`- return new()`
	`24`	`+ return new List<T>`
`25`	`25`	`{`
`26`	`26`	`element`
`27`	`27`	`};`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`public static HashSet<T> AsHashSet<T>(this T element)`
`31`	`31`	`{`
`32`		`- return new()`
	`32`	`+ return new HashSet<T>`
`33`	`33`	`{`
`34`	`34`	`element`
`35`	`35`	`};`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ protected static void WriteSubTree<TValue>(Utf8JsonWriter writer, TValue value,`
`29`	`29`
`30`	`30`	`protected static JsonException GetEndOfStreamError()`
`31`	`31`	`{`
`32`		`- return new("Unexpected end of JSON stream.");`
	`32`	`+ return new JsonException("Unexpected end of JSON stream.");`
`33`	`33`	`}`
`34`	`34`	`}`
`35`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public ResourceObjectTreeNode(IIdentifiable resource, ResourceType type, Resourc`
`51`	`51`
`52`	`52`	`public static ResourceObjectTreeNode CreateRoot()`
`53`	`53`	`{`
`54`		`- return new(RootResource, RootType, new ResourceObject());`
	`54`	`+ return new ResourceObjectTreeNode(RootResource, RootType, new ResourceObject());`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`public void AttachDirectChild(ResourceObjectTreeNode treeNode)`