Fixed: do not share NullabilityInfoContext, it is not thread-safe

Author: bkoelman

src/JsonApiDotNetCore.OpenApi/ResourceFieldAttributeExtensions.cs

@@ -7,8 +7,6 @@ namespace JsonApiDotNetCore.OpenApi;
 
 internal static class ResourceFieldAttributeExtensions
 {
-    private static readonly NullabilityInfoContext NullabilityInfoContext = new();
-
     public static bool IsNullable(this ResourceFieldAttribute source)
     {
         bool hasRequiredAttribute = source.Property.HasAttribute<RequiredAttribute>();
@@ -24,7 +22,8 @@ public static bool IsNullable(this ResourceFieldAttribute source)
             return false;
         }
 
-        NullabilityInfo nullabilityInfo = NullabilityInfoContext.Create(source.Property);
+        NullabilityInfoContext nullabilityContext = new();
+        NullabilityInfo nullabilityInfo = nullabilityContext.Create(source.Property);
 
         //  Reflects the following cases:
         //    Independent of NRT:

src/JsonApiDotNetCore.OpenApi/SwaggerComponents/ResourceFieldObjectSchemaBuilder.cs

@@ -12,8 +12,6 @@ namespace JsonApiDotNetCore.OpenApi.SwaggerComponents;
 
 internal sealed class ResourceFieldObjectSchemaBuilder
 {
-    private static readonly NullabilityInfoContext NullabilityInfoContext = new();
-
     private static readonly Type[] RelationshipSchemaInResponseOpenTypes =
     {
         typeof(ToOneRelationshipInResponse<>),
@@ -121,7 +119,8 @@ private bool IsFieldRequired(ResourceFieldAttribute field)
 
         bool hasRequiredAttribute = field.Property.HasAttribute<RequiredAttribute>();
 
-        NullabilityInfo nullabilityInfo = NullabilityInfoContext.Create(field.Property);
+        NullabilityInfoContext nullabilityContext = new();
+        NullabilityInfo nullabilityInfo = nullabilityContext.Create(field.Property);
 
         return field.Property.PropertyType.IsValueType switch
         {

test/OpenApiClientTests/PropertyInfoAssertionsExtension.cs

@@ -6,14 +6,13 @@ namespace OpenApiClientTests;
 
 internal static class PropertyInfoAssertionsExtensions
 {
-    private static readonly NullabilityInfoContext NullabilityInfoContext = new();
-
     [CustomAssertion]
     public static void BeNullable(this PropertyInfoAssertions source, string because = "", params object[] becauseArgs)
     {
         PropertyInfo propertyInfo = source.Subject;
 
-        NullabilityInfo nullabilityInfo = NullabilityInfoContext.Create(propertyInfo);
+        NullabilityInfoContext nullabilityContext = new();
+        NullabilityInfo nullabilityInfo = nullabilityContext.Create(propertyInfo);
 
         nullabilityInfo.ReadState.Should().NotBe(NullabilityState.NotNull, because, becauseArgs);
     }
@@ -23,7 +22,8 @@ public static void BeNonNullable(this PropertyInfoAssertions source, string beca
     {
         PropertyInfo propertyInfo = source.Subject;
 
-        NullabilityInfo nullabilityInfo = NullabilityInfoContext.Create(propertyInfo);
+        NullabilityInfoContext nullabilityContext = new();
+        NullabilityInfo nullabilityInfo = nullabilityContext.Create(propertyInfo);
 
         nullabilityInfo.ReadState.Should().Be(NullabilityState.NotNull, because, becauseArgs);
     }