Bugfix: relationship links were rendered for ToMany relationships, even when explicitly turned off in global options (and not configured on the relationship itself).

Author: Bart Koelman

src/JsonApiDotNetCore/Resources/Annotations/HasManyAttribute.cs

@@ -5,24 +5,17 @@ namespace JsonApiDotNetCore.Resources.Annotations
     /// <summary>
     /// Used to expose a property on a resource class as a JSON:API to-many relationship (https://jsonapi.org/format/#document-resource-object-relationships).
     /// </summary>
+    /// <example>
+    /// <code><![CDATA[
+    /// public class Author : Identifiable 
+    /// {
+    ///     [HasMany(PublicName = "articles")]
+    ///     public List<Article> Articles { get; set; }
+    /// }
+    /// ]]></code>
+    /// </example>
     [AttributeUsage(AttributeTargets.Property)]
     public class HasManyAttribute : RelationshipAttribute
     {
-        /// <summary>
-        /// Creates a HasMany relational link to another resource.
-        /// </summary>
-        /// <example>
-        /// <code><![CDATA[
-        /// public class Author : Identifiable 
-        /// {
-        ///     [HasMany(PublicName = "articles")]
-        ///     public List<Article> Articles { get; set; }
-        /// }
-        /// ]]></code>
-        /// </example>
-        public HasManyAttribute()
-        {
-            Links = LinkTypes.All;
-        }
     }
 }

src/JsonApiDotNetCore/Resources/Annotations/HasOneAttribute.cs

@@ -8,9 +8,5 @@ namespace JsonApiDotNetCore.Resources.Annotations
     [AttributeUsage(AttributeTargets.Property)]
     public sealed class HasOneAttribute : RelationshipAttribute
     {
-        public HasOneAttribute()
-        {
-            Links = LinkTypes.NotConfigured;
-        }
     }
 }

src/JsonApiDotNetCore/Resources/Annotations/RelationshipAttribute.cs

@@ -10,7 +10,7 @@ namespace JsonApiDotNetCore.Resources.Annotations
     /// </summary>
     public abstract class RelationshipAttribute : ResourceFieldAttribute
     {
-        private LinkTypes _links;
+        private LinkTypes _links = LinkTypes.NotConfigured;
 
         /// <summary>
         /// The property name of the EF Core inverse navigation, which may or may not exist.
@@ -62,8 +62,7 @@ public abstract class RelationshipAttribute : ResourceFieldAttribute
         /// When not explicitly assigned, the default value depends on the relationship type (see remarks).
         /// </summary>
         /// <remarks>
-        /// This defaults to <see cref="LinkTypes.All"/> for <see cref="HasManyAttribute"/> and <see cref="HasManyThroughAttribute"/> relationships.
-        /// This defaults to <see cref="LinkTypes.NotConfigured"/> for <see cref="HasOneAttribute"/> relationships, which means that
+        /// This defaults to <see cref="LinkTypes.NotConfigured"/>, which means that
         /// the configuration in <see cref="IJsonApiOptions"/> or <see cref="ResourceContext"/> is used.
         /// </remarks>
         public LinkTypes Links