Skip to content

Links do not include the "include=..." query parameter #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ludydoo opened this issue Jan 30, 2019 · 1 comment
Closed

Links do not include the "include=..." query parameter #468

ludydoo opened this issue Jan 30, 2019 · 1 comment
Labels

Comments

@ludydoo
Copy link

ludydoo commented Jan 30, 2019

Awesome library.

Description

When GETtting a collection of resources, the generated Paging RootLinks (next, prev, ...) do not include the &include=... query parameter that was initially passed.

GET http://localhost:21021/telephones?page[size]=5&page[number]=4&include=locators

Result :

next: "http://localhost:21021/telephones?page[size]=5&page[number]=5",
prev: "http://localhost:21021/telephones?page[size]=5&page[number]=3",
first: "http://localhost:21021/telephones?page[size]=5&page[number]=1",
last: "http://localhost:21021/telephones?page[size]=5&page[number]=11"

Expected

next: "http://localhost:21021/telephones?page[size]=5&page[number]=5&include=locators",
prev: "http://localhost:21021/telephones?page[size]=5&page[number]=3&include=locators",
first: "http://localhost:21021/telephones?page[size]=5&page[number]=1&include=locators",
last: "http://localhost:21021/telephones?page[size]=5&page[number]=11&include=locators"

Environment

  • JsonApiDotNetCore Version: Latest
  • Other Relevant Package Versions:
@jaredcnance
Copy link
Contributor

Thanks for opening this. I've added this to #276 to track as a single ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants