Namespace not honored when RelativeLinks=true

[fdlane]

Description

In the GettingStarted App if you set RelativeLinks = true; the links in response do not include the namespace. Should it not return "self": "api/people"?

services.AddJsonApi<SampleDbContext>(options =>
    {
        options.Namespace = "api";
        options.RelativeLinks = true;
     });

{
    "links": {
        "self": "/people"
    },
    "data": [
        {
            "type": "people",
            "id": "1",
            "attributes": {
                "name": "John Doe"
            },
            "relationships": {
                "articles": {
                    "links": {
                        "self": "/people/1/relationships/articles",
                        "related": "/people/1/articles"
...

...

Environment

• JsonApiDotNetCore Version: master
• Other Relevant Package Versions: core 3.1

[fdlane]

Is this correct?

JsonApiDotNetCore/src/JsonApiDotNetCore/Serialization/Server/Builders/LinkBuilder.cs

Line 227 in ac5b100

if (_options.RelativeLinks)

[bart-degreed]

You are right that the current behavior is wrong. I'm just wondering if it should be /api/people. Sounds like that would be more useful, according to https://stackoverflow.com/questions/2005079/absolute-vs-relative-urls.

[bart-degreed]

LinkBuilder is the place to fix this, but there's also some path parsing in JsonApiMiddleware you may want to verify.

[bart-degreed]

@fdlane Do you wanna take this one?

[fdlane]

@bart-degreed will do