Skip to content

types_test: test failures with Go 1.14 #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neild opened this issue Nov 13, 2019 · 0 comments
Open

types_test: test failures with Go 1.14 #419

neild opened this issue Nov 13, 2019 · 0 comments

Comments

@neild
Copy link

neild commented Nov 13, 2019

go run ./types_test fails several subtests of Test_symmetric when run with Go 1.14, due to the following upstream change to the handling of invalid UTF-8 data in struct fields with a json:",string" tag:
https://go-review.googlesource.com/c/go/+/193604

This commit fixes golang/go#34154. So far as I can tell, the change in behavior is a result of fixing this bug--that it, it's an intentional and correct change to encoding/json, not a new bug introduced by that commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant