Skip to content

Limit use of @none in maps to 1.1 mode #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gkellogg opened this issue Jan 23, 2018 · 3 comments
Closed

Limit use of @none in maps to 1.1 mode #571

gkellogg opened this issue Jan 23, 2018 · 3 comments
Assignees

Comments

@gkellogg
Copy link
Member

As discussed in #569 (comment), to avoid backwards-compatibility issues when compacting, the use of @none and in term selection should be limited to 1.1 mode.

@davidlehn
Copy link
Member

@gkellogg Note there is a misuse of <p> tags in the merged commit that needs to be fixed.

@davidlehn davidlehn reopened this Apr 9, 2018
@davidlehn
Copy link
Member

Are new tests needed for this or was this already covered? Looks like there are some related tests using the feature in 1.1 more. Not sure if error tests for 1.0 mode are needed or not.

@gkellogg
Copy link
Member Author

gkellogg commented Apr 9, 2018

I added tests I thought were useful, but don't think I added a negative test for 1.0. If you think it necessary, we can add it, but I believe we already have tests for language and index that show that they don't use a dictionary in 1.0 mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants