Skip to content

Remaining pruneBlankNodeIdentifiers test options. #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davidlehn opened this issue Apr 13, 2018 · 2 comments
Closed

Remaining pruneBlankNodeIdentifiers test options. #635

davidlehn opened this issue Apr 13, 2018 · 2 comments
Assignees
@gkellogg
Labels
test-suite

Comments

@davidlehn
Copy link
Member

frame-manifest.jsonld still has a few tests with the "pruneBlankNodeIdentifiers": false option. This was removed in #629. How should this be handled? @dlongley suggested the flag may be useful in 1.0 mode. Should those tests stay around and be marked as 1.0? If so then it seems implementations would have to know how to handle a flag which has no spec text. If the tests are removed then how do implementations test that flag?
@gkellogg
Copy link
Member

No, the flag’s gone, so we should make these depend on the processing mode, which can be set in the manifest.

Implementations May keep such a flag, but the CG manifest won’t reflect this.

@gkellogg
Copy link
Member

These are removed in PR #643.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gkellogg gkellogg

Labels
test-suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gkellogg @davidlehn