Skip to content

Commit ef212f5

Browse files
jdesrosiersjdesrosiers
committed
Update from PR feedback
1 parent 081a16a commit ef212f5

File tree

4 files changed

+18
-153
lines changed

4 files changed

+18
-153
lines changed

‎tests/draft2019-09/optional/format/idn-hostname.json‎

Lines changed: 4 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -302,21 +302,6 @@
302302
"data": "\u0628\u064a\u200c\u0628\u064a",
303303
"valid": true
304304
},
305-
{
306-
"description": "single label",
307-
"data": "hostname",
308-
"valid": true
309-
},
310-
{
311-
"description": "single label with hyphen",
312-
"data": "host-name",
313-
"valid": true
314-
},
315-
{
316-
"description": "single label with digits",
317-
"data": "h0stn4me",
318-
"valid": true
319-
},
320305
{
321306
"description": "single label starting with digit",
322307
"data": "1host",
@@ -426,43 +411,23 @@
426411
},
427412
{
428413
"description": "dot separator with label that is too long when separator is ignored",
429-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα.com",
414+
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπα.com",
430415
"valid": true
431416
},
432417
{
433418
"description": "ideographic full stop separator with label that is too long when separator is ignored",
434-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\u3002com",
419+
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπα\u3002com",
435420
"valid": true
436421
},
437422
{
438423
"description": "fullwidth full stop separator with label that is too long when separator is ignored",
439-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\uff0ecom",
424+
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπα\uff0ecom",
440425
"valid": true
441426
},
442427
{
443428
"description": "halfwidth ideographic full stop separator with label that is too long when separator is ignored",
444-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\uff61com",
429+
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπα\uff61com",
445430
"valid": true
446-
},
447-
{
448-
"description": "dot separator with label that is too long when separator is respected",
449-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα.com",
450-
"valid": false
451-
},
452-
{
453-
"description": "ideographic full stop separator with label that is too long when separator is respected",
454-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\u3002com",
455-
"valid": false
456-
},
457-
{
458-
"description": "fullwidth full stop separator with label that is too long when separator is respected",
459-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\uff0ecom",
460-
"valid": false
461-
},
462-
{
463-
"description": "halfwidth ideographic full stop separator with label that is too long when separator is respected",
464-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\uff61com",
465-
"valid": false
466431
}
467432
]
468433
}

‎tests/draft2020-12/optional/format/idn-hostname.json‎

Lines changed: 4 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -302,21 +302,6 @@
302302
"data": "\u0628\u064a\u200c\u0628\u064a",
303303
"valid": true
304304
},
305-
{
306-
"description": "single label",
307-
"data": "hostname",
308-
"valid": true
309-
},
310-
{
311-
"description": "single label with hyphen",
312-
"data": "host-name",
313-
"valid": true
314-
},
315-
{
316-
"description": "single label with digits",
317-
"data": "h0stn4me",
318-
"valid": true
319-
},
320305
{
321306
"description": "single label starting with digit",
322307
"data": "1host",
@@ -426,43 +411,23 @@
426411
},
427412
{
428413
"description": "dot separator with label that is too long when separator is ignored",
429-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα.com",
414+
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπα.com",
430415
"valid": true
431416
},
432417
{
433418
"description": "ideographic full stop separator with label that is too long when separator is ignored",
434-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\u3002com",
419+
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπα\u3002com",
435420
"valid": true
436421
},
437422
{
438423
"description": "fullwidth full stop separator with label that is too long when separator is ignored",
439-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\uff0ecom",
424+
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπα\uff0ecom",
440425
"valid": true
441426
},
442427
{
443428
"description": "halfwidth ideographic full stop separator with label that is too long when separator is ignored",
444-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\uff61com",
429+
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπα\uff61com",
445430
"valid": true
446-
},
447-
{
448-
"description": "dot separator with label that is too long when separator is respected",
449-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα.com",
450-
"valid": false
451-
},
452-
{
453-
"description": "ideographic full stop separator with label that is too long when separator is respected",
454-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\u3002com",
455-
"valid": false
456-
},
457-
{
458-
"description": "fullwidth full stop separator with label that is too long when separator is respected",
459-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\uff0ecom",
460-
"valid": false
461-
},
462-
{
463-
"description": "halfwidth ideographic full stop separator with label that is too long when separator is respected",
464-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\uff61com",
465-
"valid": false
466431
}
467432
]
468433
}

‎tests/draft7/optional/format/idn-hostname.json‎

Lines changed: 6 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -300,18 +300,8 @@
300300
"valid": true
301301
},
302302
{
303-
"description": "single label",
304-
"data": "hostname",
305-
"valid": true
306-
},
307-
{
308-
"description": "single label with hyphen",
309-
"data": "host-name",
310-
"valid": true
311-
},
312-
{
313-
"description": "single label with digits",
314-
"data": "h0stn4me",
303+
"description": "single label starting with digit",
304+
"data": "1host",
315305
"valid": true
316306
},
317307
{
@@ -415,43 +405,23 @@
415405
},
416406
{
417407
"description": "dot separator with label that is too long when separator is ignored",
418-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα.com",
408+
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπα.com",
419409
"valid": true
420410
},
421411
{
422412
"description": "ideographic full stop separator with label that is too long when separator is ignored",
423-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\u3002com",
413+
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπα\u3002com",
424414
"valid": true
425415
},
426416
{
427417
"description": "fullwidth full stop separator with label that is too long when separator is ignored",
428-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\uff0ecom",
418+
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπα\uff0ecom",
429419
"valid": true
430420
},
431421
{
432422
"description": "halfwidth ideographic full stop separator with label that is too long when separator is ignored",
433-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\uff61com",
423+
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπα\uff61com",
434424
"valid": true
435-
},
436-
{
437-
"description": "dot separator with label that is too long when separator is respected",
438-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα.com",
439-
"valid": false
440-
},
441-
{
442-
"description": "ideographic full stop separator with label that is too long when separator is respected",
443-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\u3002com",
444-
"valid": false
445-
},
446-
{
447-
"description": "fullwidth full stop separator with label that is too long when separator is respected",
448-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\uff0ecom",
449-
"valid": false
450-
},
451-
{
452-
"description": "halfwidth ideographic full stop separator with label that is too long when separator is respected",
453-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\uff61com",
454-
"valid": false
455425
}
456426
]
457427
}

‎tests/v1/format/idn-hostname.json‎

Lines changed: 4 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -302,21 +302,6 @@
302302
"data": "\u0628\u064a\u200c\u0628\u064a",
303303
"valid": true
304304
},
305-
{
306-
"description": "single label",
307-
"data": "hostname",
308-
"valid": true
309-
},
310-
{
311-
"description": "single label with hyphen",
312-
"data": "host-name",
313-
"valid": true
314-
},
315-
{
316-
"description": "single label with digits",
317-
"data": "h0stn4me",
318-
"valid": true
319-
},
320305
{
321306
"description": "single label starting with digit",
322307
"data": "1host",
@@ -426,43 +411,23 @@
426411
},
427412
{
428413
"description": "dot separator with label that is too long when separator is ignored",
429-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα.com",
414+
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπα.com",
430415
"valid": true
431416
},
432417
{
433418
"description": "ideographic full stop separator with label that is too long when separator is ignored",
434-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\u3002com",
419+
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπα\u3002com",
435420
"valid": true
436421
},
437422
{
438423
"description": "fullwidth full stop separator with label that is too long when separator is ignored",
439-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\uff0ecom",
424+
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπα\uff0ecom",
440425
"valid": true
441426
},
442427
{
443428
"description": "halfwidth ideographic full stop separator with label that is too long when separator is ignored",
444-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\uff61com",
429+
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπα\uff61com",
445430
"valid": true
446-
},
447-
{
448-
"description": "dot separator with label that is too long when separator is respected",
449-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα.com",
450-
"valid": false
451-
},
452-
{
453-
"description": "ideographic full stop separator with label that is too long when separator is respected",
454-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\u3002com",
455-
"valid": false
456-
},
457-
{
458-
"description": "fullwidth full stop separator with label that is too long when separator is respected",
459-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\uff0ecom",
460-
"valid": false
461-
},
462-
{
463-
"description": "halfwidth ideographic full stop separator with label that is too long when separator is respected",
464-
"data": "παράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμαπαράδειγμα\uff61com",
465-
"valid": false
466431
}
467432
]
468433
}

0 commit comments

Comments
 (0)