Skip to content

Why doesn't the applicator meta-schema define "type"? #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ssilverman opened this issue Apr 29, 2020 · 10 comments · Fixed by #963 or #968
Closed

Why doesn't the applicator meta-schema define "type"? #900

ssilverman opened this issue Apr 29, 2020 · 10 comments · Fixed by #963 or #968
Labels
clarification Items that need to be clarified in the specification core Priority: Low

Comments

@ssilverman
Copy link
Member

It seems like "type": ["object", "boolean"] is missing.

@Julian
Copy link
Member

Julian commented Apr 29, 2020

Which one? Looks present here

@ssilverman ssilverman changed the title Why doesn't the validation meta-schema define "type"? Why doesn't the applicator meta-schema define "type"? Apr 29, 2020
@ssilverman
Copy link
Member Author

ssilverman commented Apr 29, 2020

Oops. I don't know why I put "validation". I meant "applicator".

@handrews
Copy link
Contributor

@ssilverman it was either an accident, or I decided that I wanted the vocabulary schemas to constrain the keywords but not the overall type (deferring that to the dialect meta-schema, meaning the schemas that are not under /meta/ but are instead alongside it). I don't remember, and either way it's not consistent.

@Relequestual
Copy link
Member

Given the other schemas in /meta/ have it defined, it makes sense to add it ot the validation vocabulary meta-schema also.
@ssilverman Feel free to PR this.

@Relequestual
Copy link
Member

This update needs to be also made for the 2019-09 schemas, and then released to the website.

@karenetheridge
Copy link
Member

PR created in #968.

@ssilverman
Copy link
Member Author

@Relequestual I’m confused. This is already a 2019-09 schema? What else needs to change?

@ssilverman
Copy link
Member Author

Ok, I've sorted this out. It's a different branch.

@Relequestual
Copy link
Member

This is now resolved.
This change along with a few others have been cherrypicked into a PR against the 2019-09 branch.
Then the 2019-09 submodule for the website has been updated to the latest branch, so everyone can get the new meta-schemas.

@ssilverman
Copy link
Member Author

I believe this issue can be closed.

@gregsdennis gregsdennis added clarification Items that need to be clarified in the specification and removed Type: Bug labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Items that need to be clarified in the specification core Priority: Low
Projects
None yet
6 participants