Skip to content

Commit f71089a

Browse files
committed
No need to require handler names to be scoped to an object
1 parent 11dc56b commit f71089a

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

lib/rules/jsx-handler-names.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ module.exports = {
7777

7878
return {
7979
JSXAttribute(node) {
80-
if (!node.value || !node.value.expression || !node.value.expression.object) {
80+
if (!node.value || !node.value.expression) {
8181
return;
8282
}
8383

tests/lib/rules/jsx-handler-names.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ ruleTester.run('jsx-handler-names', rule, {
3232
code: '<TestComponent onChange={this.handleChange} />'
3333
}, {
3434
code: '<TestComponent onChange={this.props.onChange} />'
35+
}, {
36+
code: '<TestComponent onChange={handleChange} />'
3537
}, {
3638
code: '<TestComponent onChange={this.props.onFoo} />'
3739
}, {
@@ -99,12 +101,18 @@ ruleTester.run('jsx-handler-names', rule, {
99101
}, {
100102
code: '<TestComponent onChange={this.handlerChange} />',
101103
errors: [{message: 'Handler function for onChange prop key must begin with \'handle\''}]
104+
}, {
105+
code: '<TestComponent onChange={takeCareOfChange} />',
106+
errors: [{message: 'Handler function for onChange prop key must begin with \'handle\''}]
102107
}, {
103108
code: '<TestComponent only={this.handleChange} />',
104109
errors: [{message: 'Prop key for handleChange must begin with \'on\''}]
105110
}, {
106111
code: '<TestComponent handleChange={this.handleChange} />',
107112
errors: [{message: 'Prop key for handleChange must begin with \'on\''}]
113+
}, {
114+
code: '<TestComponent whenChange={handleChange} />',
115+
errors: [{message: 'Prop key for handleChange must begin with \'on\''}]
108116
}, {
109117
code: '<TestComponent onChange={this.onChange} />',
110118
errors: [{message: 'Handler function for onChange prop key must begin with \'handle\''}]

0 commit comments

Comments
 (0)