Skip to content

Yarn PnP compatibility #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fazouane-marouane opened this issue Mar 10, 2019 · 1 comment
Closed

Yarn PnP compatibility #2192

fazouane-marouane opened this issue Mar 10, 2019 · 1 comment

Comments

@fazouane-marouane
Copy link

Hello,

It seems that usage of https://github.com/browserify/resolve#readme instead of plain old require.resolve causes issues when trying to use eslint-plugin-react while passing this settings to eslint when using yarn pnp mode ( facebook/create-react-app#6605 )

{
  //...
  "settings": {
    "react": {
      "version": "detect"
    }
  }
}

Would you be open to a PR to change this part https://github.com/yannickcr/eslint-plugin-react/blob/master/lib/util/version.js#L14 into a require.resolve('react') ?
Thx

@ljharb
Copy link
Member

ljharb commented Mar 10, 2019

resolve already has PnP compatibility (via browserify/resolve#170). If it's not working, please file a bug on yarn.

@ljharb ljharb closed this as completed Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants