Disabling eslint rule for react/forbid-foreign-prop-types does not work on all references

[noratarano]

Summary of the issue

Here's a snippet from the code in our repo for prop types hoisting in an HOC:

function withBreakpoint<C extends React.ComponentType<any>>(WrappedComponent: C) {
  // ...

  // eslint-disable-next-line react/forbid-foreign-prop-types
  if (WrappedComponent.propTypes) {
    // eslint-disable-next-line react/forbid-foreign-prop-types
    const { currentBreakpoint, breakpoints, ...restPropTypes } = WrappedComponent.propTypes;
    WithBreakpoint.propTypes = restPropTypes as PropTypes.ValidationMap<Props>;
  }

  // ...
}

Even though linting on the the first reference of WrappedComponent.propTypes is disabled, it fails linting.

Screenshot:

Result in CI:

133:24  error    Using propTypes from another component is not safe because they may be removed in production builds  react/forbid-foreign-prop-types

Attempted solutions

❌ Didn't work

• Surrounded the statement with /* eslint-disable react/forbid-foreign-prop-types */ and /* eslint-enable react/forbid-foreign-prop-types */
• // eslint-disable-next-line to disable all rules for that line

✅ Worked

• Added /* eslint-disable react/forbid-foreign-prop-types */ at the top of the file

cc @ljharb

[ljharb]

That should certainly work. What's your eslint config and versions?

[yannickcr]

I was not able to reproduce the issue on the above snipped using [email protected] and [email protected].

[ljharb]

Closing pending confirmation of version numbers used.

[ljharb]

This was happening with eslint 5; reopening.

[yannickcr]

Was not able to reproduce it with ESLint@5 either, do you have more information @ljharb?

[ljharb]

Closing.

Happy to reopen and fix ASAP with a repro repo, or a failing test, but it's unlikely this continues to be a problem.