Skip to content

Commit 3499558

Browse files
pavelsavarajtschuster
authored andcommitted
[wasi] fix WasmTestRunnerDir (dotnet#107389)
1 parent 6e49f42 commit 3499558

File tree

5 files changed

+12
-5
lines changed

5 files changed

+12
-5
lines changed

eng/testing/tests.props

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,11 @@
1515
<!-- Test runners are built as part of libs.pretest so we need to use libraries configuration -->
1616
<AppleTestRunnerDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'AppleTestRunner', '$(Configuration)', '$(NetCoreAppCurrent)'))</AppleTestRunnerDir>
1717
<AndroidTestRunnerDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'AndroidTestRunner', '$(Configuration)', '$(NetCoreAppCurrent)'))</AndroidTestRunnerDir>
18-
<WasmTestRunnerDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'WasmTestRunner', '$(Configuration)', '$(NetCoreAppCurrent)'))</WasmTestRunnerDir>
18+
19+
<_WasmTestRunnerTFM>$(NetCoreAppCurrent)</_WasmTestRunnerTFM>
20+
<_WasmTestRunnerTFM Condition="'$(TargetsWasi)' == 'true'">$(NetCoreAppCurrent)-wasi</_WasmTestRunnerTFM>
21+
<_WasmTestRunnerTFM Condition="'$(TargetsBrowser)' == 'true'">$(NetCoreAppCurrent)-browser</_WasmTestRunnerTFM>
22+
<WasmTestRunnerDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'WasmTestRunner', '$(Configuration)', '$(_WasmTestRunnerTFM)'))</WasmTestRunnerDir>
1923

2024
<RuntimeIdentifier>$(OutputRID)</RuntimeIdentifier>
2125
<SelfContained>true</SelfContained>

eng/testing/tests.wasi.targets

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929

3030
<_AppArgs Condition="'$(IsFunctionalTest)' != 'true' and '$(WasmSingleFileBundle)' != 'true'">$(_AppArgs) managed/$(AssemblyName).dll</_AppArgs>
3131
<_AppArgs Condition="'$(IsFunctionalTest)' != 'true' and '$(WasmSingleFileBundle)' == 'true'">$(_AppArgs) $(AssemblyName).dll</_AppArgs>
32-
<_AppArgs Condition="'$(WasmTestAppArgs)' != ''">$(_AppArgs) -- $(WasmTestAppArgs)</_AppArgs>
32+
<_AppArgs Condition="'$(WasmTestAppArgs)' != ''">$(_AppArgs) $(WasmTestAppArgs)</_AppArgs>
3333

3434
<!-- FIXME: wasttime specific param name -->
3535
<WasmXHarnessMonoArgs Condition="'$(XunitShowProgress)' == 'true'">$(WasmXHarnessMonoArgs) --env=XHARNESS_LOG_TEST_START=true</WasmXHarnessMonoArgs>
@@ -49,6 +49,8 @@
4949
<_XHarnessArgs Condition="'$(WasmXHarnessTestsTimeout)' != ''" >$(_XHarnessArgs) &quot;--timeout=$(WasmXHarnessTestsTimeout)&quot;</_XHarnessArgs>
5050
<_XHarnessArgs >$(_XHarnessArgs) --engine-arg=--wasm --engine-arg=max-wasm-stack=134217728</_XHarnessArgs>
5151
<_XHarnessArgs >$(_XHarnessArgs) --engine-arg=--wasi --engine-arg=http</_XHarnessArgs>
52+
<_XHarnessArgs >$(_XHarnessArgs) --engine-arg=--wasi --engine-arg=inherit-network</_XHarnessArgs>
53+
<_XHarnessArgs >$(_XHarnessArgs) --engine-arg=--wasi --engine-arg=allow-ip-name-lookup</_XHarnessArgs>
5254
<_XHarnessArgs >$(_XHarnessArgs) --engine-arg=--env --engine-arg=DOTNET_WASI_PRINT_EXIT_CODE=1</_XHarnessArgs>
5355
<_XHarnessArgs Condition="'$(WasmXHarnessArgsCli)' != ''" >$(_XHarnessArgs) $(WasmXHarnessArgsCli)</_XHarnessArgs>
5456

src/mono/wasi/include/netdb.h

Lines changed: 0 additions & 1 deletion
This file was deleted.

src/mono/wasi/mono-include/setjmp.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,5 @@
1-
// setjmp.h isn't provided by WASI SDK, but many Mono source files want to import it, so we need this here
1+
// setjmp.h is provided by WASI SDK, complains that:
2+
// Setjmp/longjmp support requires Exception handling support, which is [not yet standardized](https://github.com/WebAssembly/proposals?tab=readme-ov-file#phase-3---implementation-phase-cg--wg).
3+
// To enable it, compile with `-mllvm -wasm-enable-sjlj` and use an engine that implements the Exception handling proposal.
4+
// many Mono source files want to import it, so we need this here
25
// We don't call any of its symbols at runtime so it can be left empty

src/native/libs/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ if (CLR_CMAKE_TARGET_UNIX OR CLR_CMAKE_TARGET_BROWSER OR CLR_CMAKE_TARGET_WASI)
4747
if (CLR_CMAKE_TARGET_WASI)
4848
set(HOST_WASI 1)
4949
add_compile_options(-I${CLR_REPO_ROOT_DIR}/src/mono/wasi/include/)
50-
add_compile_options(-I${CLR_REPO_ROOT_DIR}/src/mono/wasi/libs-include/)
5150
add_compile_options(-Wno-unused-variable)
5251
add_compile_options(-Wno-unused-parameter)
5352
add_compile_options(-Wno-gnu-statement-expression)

0 commit comments

Comments
 (0)