Skip to content

Commit 664c8e6

Browse files
committed
Follow up review on emscripten-core#13296.
1 parent f5cb661 commit 664c8e6

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

tests/core/test_dyncalls.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,22 @@ mergeInto(LibraryManager.library, {
22
test_dyncalls_vijdf: function(funcPtr) {
33
// 1. Directly access a function pointer via a static signature (32-bit ABI)
44
// (this is the fastest way to call a function pointer when the signature is statically known in WASM_BIGINT==0 builds)
5-
dynCall_vijdf(funcPtr, 1, /*lo=*/2, /*hi=*/3, 4, 5); // Available only in WASM_BIGINT != 2 builds
5+
dynCall_vijdf(funcPtr, 1, /*lo=*/2, /*hi=*/3, 4, 5); // Available only in DYNCALLS==1 builds
66

77
// 2. Access a function pointer using the convenience/legacy 'dynCall' function (32-bit ABI)
88
// (this form should never be used, it is suboptimal for performance, but provided for legacy compatibility)
9-
dynCall('vijdf', funcPtr, [2, /*lo=*/3, /*hi=*/4, 5, 6]); // Available only in WASM_BIGINT != 2 builds
9+
dynCall('vijdf', funcPtr, [2, /*lo=*/3, /*hi=*/4, 5, 6]); // Available only in DYNCALLS==1 builds
1010
},
1111

1212
test_dyncalls_iii: function(funcPtr) {
1313
// 1. Directly access a function pointer via a static signature (32-bit ABI)
1414
// (this is the fastest way to call a function pointer when the signature is statically known in WASM_BIGINT==0 builds)
15-
var ret = dynCall_iii(funcPtr, 1, 2); // Available only in WASM_BIGINT != 2 builds
15+
var ret = dynCall_iii(funcPtr, 1, 2); // Available only in DYNCALLS==1 builds
1616
console.log('iii returned ' + ret);
1717

1818
// 2. Access a function pointer using the convenience/legacy 'dynCall' function (32-bit ABI)
1919
// (this form should never be used, it is suboptimal for performance, but provided for legacy compatibility)
20-
var ret = dynCall('iii', funcPtr, [2, 3]); // Available only in WASM_BIGINT != 2 builds
20+
var ret = dynCall('iii', funcPtr, [2, 3]); // Available only in DYNCALLS==1 builds
2121
console.log('iii returned ' + ret);
2222

2323
// 3. Access a dynCall using the makeDynCall macro:

tests/test_core.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6289,12 +6289,12 @@ def test_dyncall_specific(self):
62896289
self.set_setting('EXTRA_EXPORTED_RUNTIME_METHODS', exported_runtime_methods)
62906290
self.do_run_in_out_file_test('tests', 'core', 'dyncall_specific.c')
62916291

6292-
self.set_setting('EXTRA_EXPORTED_RUNTIME_METHODS', [])
6293-
self.emcc_args = emcc_args + ['-s', 'DYNCALLS=1', '--js-library', path_from_root('tests', 'core', 'test_dyncalls.js')]
6294-
self.do_run_in_out_file_test('tests', 'core', 'test_dyncalls.c')
6292+
self.set_setting('EXTRA_EXPORTED_RUNTIME_METHODS', [])
6293+
self.emcc_args = emcc_args + ['-s', 'DYNCALLS=1', '--js-library', path_from_root('tests', 'core', 'test_dyncalls.js')]
6294+
self.do_run_in_out_file_test('tests', 'core', 'test_dyncalls.c')
62956295

6296-
self.emcc_args += ['-s', 'MINIMAL_RUNTIME=1', '-s', 'DEFAULT_LIBRARY_FUNCS_TO_INCLUDE=["$dynCall"]']
6297-
self.do_run_in_out_file_test('tests', 'core', 'test_dyncalls.c')
6296+
self.emcc_args += ['-s', 'MINIMAL_RUNTIME=1', '-s', 'DEFAULT_LIBRARY_FUNCS_TO_INCLUDE=["$dynCall"]']
6297+
self.do_run_in_out_file_test('tests', 'core', 'test_dyncalls.c')
62986298

62996299
def test_getValue_setValue(self):
63006300
# these used to be exported, but no longer are by default

0 commit comments

Comments
 (0)