Skip to content

Commit 9a003a6

Browse files
committed
More ts-ignores, we need those for when we build with ipywidgets 7
locally if that happens Signed-off-by: martinRenou <[email protected]>
1 parent b194176 commit 9a003a6

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

js/datagrid.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,9 @@ import {
1818
DOMWidgetView,
1919
ICallbacks,
2020
ISerializers,
21+
// @ts-ignore needed for ipywidgetx 8.x compatibility
2122
JupyterLuminoPanelWidget,
22-
//@ts-ignore needed for ipywidgetx 7.x compatibility
23+
// @ts-ignore needed for ipywidgetx 7.x compatibility
2324
JupyterPhosphorPanelWidget,
2425
resolvePromisesDict,
2526
unpack_models,
@@ -371,7 +372,7 @@ export class DataGridView extends DOMWidgetView {
371372
// ipywidgets 7 compatibility
372373
_processLuminoMessage(
373374
msg: Message,
374-
_super: DOMWidgetView['processLuminoMessage'],
375+
_super: any,
375376
): void {
376377
_super.call(this, msg);
377378

@@ -385,11 +386,12 @@ export class DataGridView extends DOMWidgetView {
385386
}
386387

387388
processLuminoMessage(msg: Message): void {
389+
// @ts-ignore needed for ipywidgets 8.x compatibility
388390
this._processLuminoMessage(msg, super.processLuminoMessage);
389391
}
390392

391393
processPhosphorMessage(msg: Message): void {
392-
//@ts-ignore needed for ipywidgets 7.x compatibility
394+
// @ts-ignore needed for ipywidgets 7.x compatibility
393395
this._processLuminoMessage(msg, super.processPhosphorMessage);
394396
}
395397

@@ -722,6 +724,7 @@ export class DataGridView extends DOMWidgetView {
722724
default_renderer: CellRendererView;
723725
header_renderer: CellRendererView;
724726
grid: FeatherGrid;
727+
// @ts-ignore needed for ipywidgetx 8.x compatibility
725728
luminoWidget: JupyterLuminoPanelWidget;
726729
model: DataGridModel;
727730
backboneModel: DataGridModel;
@@ -766,7 +769,7 @@ export namespace DataGridModel {
766769
*/
767770
namespace Private {
768771
export function getWidgetPanel(): any {
769-
//@ts-ignore needed for ipywidget 7.x compatibility
772+
// @ts-ignore needed for ipywidget 7.x compatibility
770773
return JupyterLuminoPanelWidget ?? JupyterPhosphorPanelWidget;
771774
}
772775

0 commit comments

Comments
 (0)