Skip to content

Commit 1aeb7ee

Browse files
authored
Merge pull request #2418 from SylvainCorlay/drop-postcss
Drop postcss
2 parents 36fe375 + 15c045c commit 1aeb7ee

File tree

8 files changed

+6
-49
lines changed

8 files changed

+6
-49
lines changed

examples/web1/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Create a widget manager instance.
22
var WidgetManager = require('./manager').WidgetManager;
33

4-
require('@jupyter-widgets/controls/css/widgets.built.css');
4+
require('@jupyter-widgets/controls/css/widgets.css');
55

66
document.addEventListener("DOMContentLoaded", function(event) {
77
var manager = new WidgetManager(document.body);

examples/web2/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ require("codemirror/lib/codemirror.css");
33
require("codemirror/mode/python/python");
44
var WidgetManager = require("./manager").WidgetManager;
55

6-
require('@jupyter-widgets/controls/css/widgets.built.css');
6+
require('@jupyter-widgets/controls/css/widgets.css');
77
require('font-awesome/css/font-awesome.css');
88

99
document.addEventListener("DOMContentLoaded", function(event) {

packages/controls/css/widgets.css

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,5 @@
22
* Distributed under the terms of the Modified BSD License.
33
*/
44

5-
/* We import all of these together in a single css file because the Webpack
6-
loader sees only one file at a time. This allows postcss to see the variable
7-
definitions when they are used. */
8-
95
@import "./labvariables.css";
106
@import "./widgets-base.css";

packages/html-manager/package.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,6 @@
6161
"karma-mocha": "^1.3.0",
6262
"karma-mocha-reporter": "^2.2.3",
6363
"mocha": "^3.3.0",
64-
"postcss": "^6.0.2",
65-
"postcss-cssnext": "^3.0.2",
66-
"postcss-import": "^10.0.0",
67-
"postcss-loader": "^2.0.6",
6864
"rimraf": "^2.6.1",
6965
"style-loader": "^0.18.1",
7066
"tslint": "^5.8.0",

packages/html-manager/src/libembed.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ __webpack_public_path__ = (window as any).__jupyter_widgets_assets_path__ || __w
66

77
import 'font-awesome/css/font-awesome.css';
88
import '@phosphor/widgets/style/index.css';
9-
import '@jupyter-widgets/controls/css/widgets.built.css';
9+
import '@jupyter-widgets/controls/css/widgets.css';
1010

1111
// Used just for the typing. We must not import the javascript because we don't
1212
// want to include it in the require embedding.

packages/html-manager/webpack.config.js

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -7,33 +7,10 @@ var path = require('path');
77

88
var version = require('./package.json').version;
99

10-
var postcss = require('postcss');
11-
1210
var rules = [
1311
{ test: /\.css$/, use: [
1412
'style-loader',
15-
'css-loader',
16-
{
17-
loader: 'postcss-loader',
18-
options: {
19-
plugins: [
20-
postcss.plugin('delete-tilde', function() {
21-
return function (css) {
22-
css.walkAtRules('import', function(rule) {
23-
rule.params = rule.params.replace('~', '');
24-
});
25-
};
26-
}),
27-
postcss.plugin('prepend', function() {
28-
return function(css) {
29-
css.prepend("@import '@jupyter-widgets/controls/css/labvariables.css';")
30-
}
31-
}),
32-
require('postcss-import')(),
33-
require('postcss-cssnext')()
34-
]
35-
}
36-
}
13+
'css-loader'
3714
]},
3815
// jquery-ui loads some images
3916
{ test: /\.(jpg|png|gif)$/, use: 'file-loader' },

widgetsnbextension/package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@
3434
"devDependencies": {
3535
"css-loader": "^0.28.4",
3636
"json-loader": "^0.5.4",
37-
"postcss-cssnext": "^3.0.2",
38-
"postcss-import": "^10.0.0",
39-
"postcss-loader": "^2.0.6",
4037
"rimraf": "^2.6.1",
4138
"style-loader": "^0.18.1",
4239
"webpack": "^3.5.5"

widgetsnbextension/webpack.config.js

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,7 @@ module.exports = {
1111
rules: [
1212
{ test: /\.css$/, use: [
1313
'style-loader',
14-
'css-loader',
15-
{
16-
loader: 'postcss-loader',
17-
options: {
18-
plugins: [
19-
require('postcss-import'),
20-
require('postcss-cssnext')
21-
]
22-
}
23-
}
14+
'css-loader'
2415
]},
2516
// jquery-ui loads some images
2617
{ test: /\.(jpg|png|gif)$/, use: 'file-loader' },
@@ -30,6 +21,6 @@ module.exports = {
3021
{ test: /\.ttf(\?v=\d+\.\d+\.\d+)?$/, use: 'url-loader?limit=10000&mimetype=application/octet-stream' },
3122
{ test: /\.eot(\?v=\d+\.\d+\.\d+)?$/, use: 'file-loader' },
3223
{ test: /\.svg(\?v=\d+\.\d+\.\d+)?$/, use: 'url-loader?limit=10000&mimetype=image/svg+xml' }
33-
]
24+
]
3425
},
3526
};

0 commit comments

Comments
 (0)