Skip to content

Commit 3c2daa2

Browse files
committed
Pass change options into update calls
We assume these options several places in the code, for example in the selection widget views, but we were never passing them through when we called the update method.
1 parent e3d8fe5 commit 3c2daa2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/base/src/widget.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -737,13 +737,13 @@ export class WidgetView extends NativeView<WidgetModel> {
737737
* Initializer, called at the end of the constructor.
738738
*/
739739
initialize(parameters: WidgetView.IInitializeParameters): void {
740-
this.listenTo(this.model, 'change', () => {
740+
this.listenTo(this.model, 'change', (model, options) => {
741741
const changed = Object.keys(this.model.changedAttributes() || {});
742742
if (changed[0] === '_view_count' && changed.length === 1) {
743743
// Just the view count was updated
744744
return;
745745
}
746-
this.update();
746+
this.update(options);
747747
});
748748

749749
this.options = parameters.options;

0 commit comments

Comments
 (0)