Drop support for mutable types as Dropdown options

Author: jtpio

ipywidgets/widgets/tests/test_interaction.py

@@ -182,40 +182,6 @@ def test_list_tuple_invalid():
             print(bad) # because there is no custom message in assert_raises
             c = interactive(f, tup=bad)
 
-def test_dict():
-    for d in [
-        dict(a=5),
-        dict(a=5, b='b', c=dict),
-    ]:
-        c = interactive(f, d=d)
-        w = c.children[0]
-        check = dict(
-            cls=widgets.Dropdown,
-            description='d',
-            value=next(iter(d.values())),
-            options=d,
-            _options_labels=tuple(d.keys()),
-            _options_values=tuple(d.values()),
-        )
-        check_widget(w, **check)
-
-
-def test_ordereddict():
-    from collections import OrderedDict
-    items = [(3, 300), (1, 100), (2, 200)]
-    first = items[0][1]
-    values = OrderedDict(items)
-    c = interactive(f, lis=values)
-    assert len(c.children) == 2
-    d = dict(
-        cls=widgets.Dropdown,
-        value=first,
-        options=values,
-        _options_labels=("3", "1", "2"),
-        _options_values=(300, 100, 200),
-    )
-    check_widgets(c, lis=d)
-
 def test_iterable():
     def yield_values():
         yield 3

ipywidgets/widgets/tests/test_widget_selection.py

@@ -1,8 +1,6 @@
 # Copyright (c) Jupyter Development Team.
 # Distributed under the terms of the Modified BSD License.
 
-import inspect
-import warnings
 from unittest import TestCase
 
 from traitlets import TraitError
@@ -15,20 +13,6 @@ class TestDropdown(TestCase):
     def test_construction(self):
         Dropdown()
 
-    def test_deprecation_warning_mapping_options(self):
-        with warnings.catch_warnings(record=True) as w:
-            warnings.simplefilter("always")
-
-            # Clearing the internal __warningregistry__ seems to be required for
-            # Python 2 (but not for Python 3)
-            module = inspect.getmodule(Dropdown)
-            getattr(module, '__warningregistry__', {}).clear()
-
-            Dropdown(options={'One': 1, 'Two': 2, 'Three': 3})
-            assert len(w) > 0
-            assert issubclass(w[-1].category, DeprecationWarning)
-            assert "Support for mapping types has been deprecated" in str(w[-1].message)
-
 
 class TestSelectionSlider(TestCase):
 

ipywidgets/widgets/widget_selection.py

@@ -106,12 +106,6 @@ def _make_options(x):
     * an iterable of (label, value) pairs
     * an iterable of values, and labels will be generated
     """
-    # Check if x is a mapping of labels to values
-    if isinstance(x, Mapping):
-        import warnings
-        warnings.warn("Support for mapping types has been deprecated and will be dropped in a future release.", DeprecationWarning)
-        return tuple((str(k), v) for k, v in x.items())
-
     # only iterate once through the options.
     xlist = tuple(x)