Skip to content

Review protocol for consistency #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
jasongrout opened this issue Mar 18, 2017 · 4 comments
Closed
1 task done

Review protocol for consistency #1212

jasongrout opened this issue Mar 18, 2017 · 4 comments
Labels
protocol resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jasongrout
Copy link
Member

jasongrout commented Mar 18, 2017

With #1207, it is painfully clear that we should review the protocol messages for consistency. For example, the sync messages are needlessly different depending on the direction between the backend and the frontend.

Also, it's very weird that the comm_open messages from the frontend to the backend give a magic string, but the comm_open messages from the backend to the frontend just give the state. I think the problem here is that you can have multiple kernel-side implementations of the same syncing data model (like IntProgress and FloatProgress I believe use the exact same javascript model with different defaults). This is especially weird since each model on the front end should have the same defaults as the model in the kernel, but can't if there is a one to many relationship. Perhaps we should insist on basically having a 1:1 correspondence between frontend and backend models, so that the synced attributes define the widget.

@jasongrout
Copy link
Member Author

Some of the inconsistency (in how buffers are used) is taken care of in #1194, thanks to @maartenbreddels great efforts!

@SylvainCorlay
Copy link
Member

There are some intrinsic reasons for some of the asymmetry. The request state message only makes sense from the front end to the backend. (The front-ends eventually can become transient and the backend long living.)
I agree on other items but symmetry is not required everywhere.

@jasongrout
Copy link
Member Author

Yep, +1 to the request state message staying asymmetric.

@jasongrout
Copy link
Member Author

This is now done with the merge of #1228.

@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
protocol resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

2 participants