code to reproduce output from "Widgets -> Embed Widgets"

[hainm]

hi,

I am working embedding nglview. The "Widgets -> Embed Widgets" works nicely (I can see the render after open the html file).

However, using the python API won't give the same expectation.

embed.embed_minimal_html('index2.html', [view], requirejs=True)

I guess I miss something here. Can you help? thanks

[hainm]

Please see attach files for working (with "Widgets -> Embed Widgets") and non_working html
(from API)

working.txt

non_working.txt

[jasongrout]

The non-working example is missing some key properties in the widget state, namely the _view_* properties.

[hainm]

Is that intentional?

[hainm]

uhm, I actually get the same error if trying sphinx-jupyter PR from jupyter/jupyter-sphinx#16

[hainm]

By the way, ipywidgets 7 is awesome and I love it much. ;)

[jasongrout]

It is intentional (default is to get the data without default values). I'm considering whether it is the best, though. Usually these _view_* properties are set as defaults in javascript. Do your javascript models have the appropriate _view_* defaults defined?

[jasongrout]

The defaults are only defined on the model, not the view. The defaults defined at https://github.com/arose/nglview/blob/master/js/src/widget_ngl.js#L27 should be moved up to the model at https://github.com/arose/nglview/blob/master/js/src/widget_ngl.js#L17

(That also explains why the javascript embedding worked - it also deleted any default values, but since you didn't define defaults for the view information, that was saved in the document.)

[jasongrout]

By the way, ipywidgets 7 is awesome and I love it much. ;)

Thanks! And thanks for testing things out!

[hainm]

Do your javascript models have the appropriate view* defaults defined?

I am not sure what you meant here (due to my lack of understanding about how ipywidgets works).

But below is a short chunk of codes:
https://github.com/arose/nglview/blob/84a5873d98a703e1057b845026faae6aa4130f60/js/src/widget_ngl.js#L16-L36

[hainm]

It is intentional (default is to get the data without default values).

so, are you going to change it? If not yet, what's the idiom to make nglview work with sphinx-jupyter? thanks.

[jasongrout]

Move these three lines (https://github.com/arose/nglview/blob/master/js/src/widget_ngl.js#L32-L34) to here (https://github.com/arose/nglview/blob/master/js/src/widget_ngl.js#L22). Delete the defaults() function in the view.

[hainm]

wow, work like a charm. Thanks Jason. (see the attached wow.txt (-> wow.html) and the figure).

wow.txt

cc @arose

Happy to close this issue.

@jasongrout PS: May be updating docs if there is not yet. :)