Merge pull request #1635 from mathbunnyru/asalikhov/fix_cython

Fix cython in scipy-notebook

Author: mathbunnyru

scipy-notebook/Dockerfile

@@ -8,9 +8,15 @@ LABEL maintainer="Jupyter Project <[email protected]>"
 
 USER root
 
-# ffmpeg for matplotlib anim & dvipng+cm-super for latex labels
 RUN apt-get update --yes && \
-    apt-get install --yes --no-install-recommends ffmpeg dvipng cm-super && \
+    apt-get install --yes --no-install-recommends \
+    # for cython: https://cython.readthedocs.io/en/latest/src/quickstart/install.html
+    build-essential \
+    # for latex labels
+    cm-super \
+    dvipng \
+    # for matplotlib anim
+    ffmpeg && \
     apt-get clean && rm -rf /var/lib/apt/lists/*
 
 USER ${NB_UID}

tests/pytest.ini

@@ -1,7 +1,7 @@
 [pytest]
 addopts = -ra --color=yes
 log_cli = 1
-log_cli_level = INFO
+log_cli_level = DEBUG
 log_cli_format = %(asctime)s [%(levelname)8s] %(message)s (%(filename)s:%(lineno)s)
 log_cli_date_format=%Y-%m-%d %H:%M:%S
 markers =

tests/scipy-notebook/data/cython/helloworld.pyx

@@ -0,0 +1 @@
+print("Hello World")

tests/scipy-notebook/data/cython/setup.py

@@ -0,0 +1,4 @@
+from setuptools import setup
+from Cython.Build import cythonize
+
+setup(ext_modules=cythonize("helloworld.pyx"))

tests/scipy-notebook/test_cython.py

@@ -0,0 +1,27 @@
+# Copyright (c) Jupyter Development Team.
+# Distributed under the terms of the Modified BSD License.
+
+from pathlib import Path
+
+from conftest import TrackedContainer
+
+THIS_DIR = Path(__file__).parent.resolve()
+
+
+def test_cython(container: TrackedContainer) -> None:
+    host_data_dir = THIS_DIR / "data/cython"
+    cont_data_dir = "/home/jovyan/data"
+
+    logs = container.run_and_wait(
+        timeout=10,
+        volumes={str(host_data_dir): {"bind": cont_data_dir, "mode": "ro"}},
+        tty=True,
+        command=[
+            "start.sh",
+            "bash",
+            "-c",
+            # We copy our data to temporary folder to be able to modify the directory
+            f"cp -r {cont_data_dir}/ /tmp/test/ && cd /tmp/test && python3 setup.py build_ext",
+        ],
+    )
+    assert "building 'helloworld' extension" in logs