Skip to content

Commit 5cb1a91

Browse files
authored
Merge pull request #1634 from mathbunnyru/asalikhov/test_all
Run tests on all children images
2 parents d719598 + d22a074 commit 5cb1a91

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+163
-104
lines changed

.github/workflows/docker-amd64.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,8 @@ on:
1818
- "tensorflow-notebook/**"
1919

2020
- "tagging/**"
21-
- "test/**"
22-
- "conftest.py"
21+
- "tests/**"
2322
- "Makefile"
24-
- "pytest.ini"
2523
- "requirements-dev.txt"
2624
push:
2725
branches:
@@ -40,10 +38,8 @@ on:
4038
- "tensorflow-notebook/**"
4139

4240
- "tagging/**"
43-
- "test/**"
44-
- "conftest.py"
41+
- "tests/**"
4542
- "Makefile"
46-
- "pytest.ini"
4743
- "requirements-dev.txt"
4844
workflow_dispatch:
4945

.github/workflows/docker.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,8 @@ on:
1818
- "tensorflow-notebook/**"
1919

2020
- "tagging/**"
21-
- "test/**"
22-
- "conftest.py"
21+
- "tests/**"
2322
- "Makefile"
24-
- "pytest.ini"
2523
- "requirements-dev.txt"
2624
push:
2725
branches:
@@ -40,10 +38,8 @@ on:
4038
- "tensorflow-notebook/**"
4139

4240
- "tagging/**"
43-
- "test/**"
44-
- "conftest.py"
41+
- "tests/**"
4542
- "Makefile"
46-
- "pytest.ini"
4743
- "requirements-dev.txt"
4844
workflow_dispatch:
4945

Makefile

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ build-all-multi: $(foreach I, $(MULTI_IMAGES), build-multi/$(I)) $(foreach I, $(
113113

114114

115115
check-outdated/%: ## check the outdated mamba/conda packages in a stack and produce a report (experimental)
116-
@TEST_IMAGE="$(OWNER)/$(notdir $@)" pytest test/test_outdated.py
116+
@TEST_IMAGE="$(OWNER)/$(notdir $@)" pytest tests/base-notebook/test_outdated.py
117117
check-outdated-all: $(foreach I, $(ALL_IMAGES), check-outdated/$(I)) ## check all the stacks for outdated packages
118118

119119

@@ -205,9 +205,8 @@ run-sudo-shell/%: ## run a bash in interactive mode as root in a stack
205205

206206

207207

208-
test/%: ## run tests against a stack (only common tests or common tests + specific tests)
208+
test/%: ## run tests against a stack
209209
@echo "::group::test/$(OWNER)/$(notdir $@)"
210-
@if [ ! -d "$(notdir $@)/test" ]; then TEST_IMAGE="$(OWNER)/$(notdir $@)" pytest --numprocesses=auto -m "not info" test; \
211-
else TEST_IMAGE="$(OWNER)/$(notdir $@)" pytest --numprocesses=auto -m "not info" test $(notdir $@)/test; fi
210+
tests/run_tests.py --short-image-name "$(notdir $@)" --owner "$(OWNER)"
212211
@echo "::endgroup::"
213212
test-all: $(foreach I, $(ALL_IMAGES), test/$(I)) ## test all stacks

all-spark-notebook/.dockerignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
# Documentation
22
README.md
3-
test

base-notebook/.dockerignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
# Documentation
22
README.md
3-
test

datascience-notebook/.dockerignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
# Documentation
22
README.md
3-
test

docs/contributing/tests.md

Lines changed: 28 additions & 20 deletions

minimal-notebook/.dockerignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
# Documentation
22
README.md
3-
test

pyspark-notebook/.dockerignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
# Documentation
22
README.md
3-
test

r-notebook/.dockerignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
# Documentation
22
README.md
3-
test

0 commit comments

Comments
 (0)