Skip to content

Commit 5eca3ca

Browse files
committed
stop removing qt
it makes the conda env invalid, which causes errors in later installs
1 parent 50ae9cd commit 5eca3ca

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,4 +87,4 @@ test/%: ## run tests against a stack
8787
@TEST_IMAGE="$(OWNER)/$(notdir $@)" pytest test
8888

8989
test/base-notebook: ## test supported options in the base notebook
90-
@TEST_IMAGE="$(OWNER)/$(notdir $@)" pytest test base-notebook/test
90+
@TEST_IMAGE="$(OWNER)/$(notdir $@)" pytest test base-notebook/test

scipy-notebook/Dockerfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ RUN apt-get update && \
1515
USER $NB_UID
1616

1717
# Install Python 3 packages
18-
# Remove pyqt and qt pulled in for matplotlib since we're only ever going to
19-
# use notebook-friendly backends in these images
2018
RUN conda install --quiet --yes \
2119
'conda-forge::blas=*=openblas' \
2220
'ipywidgets=7.4*' \
@@ -43,7 +41,6 @@ RUN conda install --quiet --yes \
4341
'beautifulsoup4=4.7.*' \
4442
'protobuf=3.7.*' \
4543
'xlrd' && \
46-
conda remove --quiet --yes --force qt pyqt && \
4744
conda clean --all -f -y && \
4845
# Activate ipywidgets extension in the environment that runs the notebook server
4946
jupyter nbextension enable --py widgetsnbextension --sys-prefix && \

0 commit comments

Comments
 (0)