Removed the possibility for cameraSettings to be undefined in the getter and setter, and update updateCameraSettings command accordingly.

Author: HaudinFlorence

packages/base/src/3dview/mainview.tsx

@@ -1536,7 +1536,7 @@ export class MainView extends React.Component<IProps, IStates> {
     }
 
     if (change.key === 'cameraSettings') {
-      const cameraSettings = change.newValue as CameraSettings | undefined;
+      const cameraSettings = change.newValue as CameraSettings;
 
       if (change.type !== 'remove' && cameraSettings) {
         this._cameraSettings = cameraSettings;

packages/base/src/commands.ts

@@ -1068,21 +1068,16 @@ export function addCommands(
     icon: videoSolidIcon,
     isToggled: () => {
       const current = tracker.currentWidget?.content;
-      return current?.cameraSettings?.type === 'Orthographic';
+      return current?.cameraSettings.type === 'Orthographic';
     },
     execute: async () => {
       const current = tracker.currentWidget;
       if (!current) {
         return;
       } else {
-        const currentSettings: CameraSettings | undefined =
-          current.content.cameraSettings;
-        if (currentSettings) {
-          if (currentSettings.type === 'Perspective') {
-            current.content.cameraSettings = { type: 'Orthographic' };
-          } else {
-            current.content.cameraSettings = { type: 'Perspective' };
-          }
+        const currentSettings: CameraSettings = current.content.cameraSettings;
+        if (currentSettings.type === 'Perspective') {
+          current.content.cameraSettings = { type: 'Orthographic' };
         } else {
           current.content.cameraSettings = { type: 'Perspective' };
         }

packages/base/src/widget.ts

@@ -176,12 +176,12 @@ export class JupyterCadPanel extends SplitPanel {
     this._view.set('explodedView', value || null);
   }
 
-  get cameraSettings(): CameraSettings | undefined {
+  get cameraSettings(): CameraSettings {
     return this._view.get('cameraSettings') as CameraSettings;
   }
 
-  set cameraSettings(value: CameraSettings | undefined) {
-    this._view.set('cameraSettings', value || null);
+  set cameraSettings(value: CameraSettings) {
+    this._view.set('cameraSettings', value);
   }
 
   get clipView(): ClipSettings | undefined {